Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to Delete Masks by Setting Property to Null #567

Merged
merged 8 commits into from
Nov 24, 2021
Merged

Conversation

jonobr1
Copy link
Owner

@jonobr1 jonobr1 commented Nov 24, 2021

This used to error:

var mask = new Two.Rectangle(0, 0, width, height);
var group = new Two.Group();
group.mask = mask;
group.mask = null;

Now it doesn't and properly decouples any bindings between the mask and its underlying group.

@jonobr1 jonobr1 merged commit 90467b6 into dev Nov 24, 2021
@jonobr1 jonobr1 deleted the null-mask branch November 24, 2021 18:09
elShiaLabeouf pushed a commit to elShiaLabeouf/two.js that referenced this pull request Dec 17, 2021
Possible to Delete Masks by Setting Property to Null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant