Skip to content

Commit

Permalink
src: update f function call comment
Browse files Browse the repository at this point in the history
Commit a01e8bc (src: moving f function call comment, 2016-09-04) moved
a comment to be closer to the place in the code it was describing.
While working on this there was feedback on the comment
itself:
https://github.com/nodejs/node/commit/
a01e8bc#comments

This PR includes the suggestions in the above comments.

PR-URL: nodejs#8416
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Franziska Hinkelmann <franzih@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
danbev committed Sep 7, 2016
1 parent 801115d commit 8afde12
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3418,11 +3418,11 @@ void LoadEnvironment(Environment* env) {
global->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "global"), global);

// Now we call 'f' with the 'process' variable that we've built up with
// all our bindings. Inside bootstrap_node.js we'll take care of
// assigning things to their places.
// all our bindings. Inside bootstrap_node.js and internal/process we'll
// take care of assigning things to their places.

// We start the process this way in order to be more modular. Developers
// who do not like how bootstrap_node.js setups the module system but do
// who do not like how bootstrap_node.js sets up the module system but do
// like Node's I/O bindings may want to replace 'f' with their own function.
Local<Value> arg = env->process_object();
f->Call(Null(env->isolate()), 1, &arg);
Expand Down

0 comments on commit 8afde12

Please sign in to comment.