forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stream: fix no data on partial decode
Before this commit, it was possible to push a partial character to a readable stream where it was decoded as an empty string and then added to the internal buffer. This caused the stream to not emit any data, even when the rest of the character bytes were pushed separately, because of a non-zero length check of the first chunk in the internal buffer. Fixes: nodejs#5223 PR-URL: nodejs#5226 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
45 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
'use strict'; | ||
require('../common'); | ||
const Readable = require('_stream_readable'); | ||
const assert = require('assert'); | ||
|
||
var buf = ''; | ||
const euro = new Buffer([0xE2, 0x82, 0xAC]); | ||
const cent = new Buffer([0xC2, 0xA2]); | ||
const source = Buffer.concat([euro, cent]); | ||
|
||
const readable = Readable({ encoding: 'utf8' }); | ||
readable.push(source.slice(0, 2)); | ||
readable.push(source.slice(2, 4)); | ||
readable.push(source.slice(4, 6)); | ||
readable.push(null); | ||
|
||
readable.on('data', function(data) { | ||
buf += data; | ||
}); | ||
|
||
process.on('exit', function() { | ||
assert.strictEqual(buf, '€¢'); | ||
}); |