Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_actionlogs] After deselecting all events to disable logging, checkboxes remain ticked #22627

Closed
PhilETaylor opened this issue Oct 15, 2018 · 6 comments

Comments

@PhilETaylor
Copy link
Contributor

Steps to reproduce the issue

Joomla 3.9 RC1
Click Options in Action Logs screen
deselect all events to be logged (thus disabling logging)
Click save

Expected result

Page reloads with green configuration saved notice
Checkboxes are all NOT checked

Actual result

Page reloads with green configuration saved notice
Checkboxes are all CHECKED again

System information (as much as possible)

Google Chrome, no JS errors in console

screen recording 2018-10-15 at 10 11 am

@mbabker
Copy link
Contributor

mbabker commented Oct 15, 2018

Expected behavior based on the current form definition. Having no items checked means the field is empty which means the form API applies the default value to the field, which is all extensions.

@PhilETaylor

This comment was marked as abuse.

@cyrezdev
Copy link
Contributor

cyrezdev commented Oct 15, 2018

Expected behavior based on the current form definition. Having no items checked means the field is empty which means the form API applies the default value to the field, which is all extensions.

If you uncheck all extensions, and save, no extension will be logged (as default is not stored in params, and no value is then stored for loggable_extensions param) but opening again the config shows core extensions checked...

I think action logs could be an opt-in system, and maybe with improvement to be able to check all or none on one click :
capture d ecran 2018-10-15 a 19 20 16
The screen capture is an attempt i've tried using treeselectmenu.jquery.min.js to integrate a select all / none (a simplified version of module pages assignment system).

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22627

@Quy
Copy link
Contributor

Quy commented Oct 17, 2018

Please test PR #22627


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22627.

@cyrezdev
Copy link
Contributor

cyrezdev commented Oct 17, 2018

@Quy, PR to test is #22674 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants