-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] User defined Hide Table Columns: unattractive list display #38503
Comments
Should be a more specific selector, otherwise it would also affect other pulldowns, e.g. the pulldown menu from the menu module. |
It is not quite consistent The columns have icons and it is not obvious which icon belongs to which entry (use persian or chinese language). Would it be possible to use icons (with invisible text) instead of long names? @brianteeman |
Anything is possible but I don't understand your request |
As far as I understand @chmst , she wants to use icons instead of the column titles. Have fun in a list view with 15 or 20 columns to find icons which are sufficiently distinguable from each other so you quickly can see to which of the 15 or 20 columns they belong. In my opinion a silly idea, and I haven’t seen any software which does it that way, chose the columns to be displayed in a table by an icon and not the (full or shortened) title. In my opinion a silly idea which is not practicable and result in bad ux and due to small icons maybe also bad accessibility. |
Thats what I thought it meant but for the reasons you stated I think it must be something else |
please test #38507 |
Meanwhile I had a closer look on the issue, and I must admit that I've made a mistake. I was not aware of the fact that we already use in diverse list views for some columns an icon and for some other columns a text as column title, and so I thought the icons were a new idea for the column selection dropdown of the show or hide columns feature. I understand now that @chmst only wanted to make the column titles in that dropdown equal to the column titles in the table. Currently they aren't equal, e.g. we have an icon for the status column's title in the table and a text in the dropdown, and so it's not always clear to which column belongs what (except of course by the order, that should be equal). But I still think a mix of icons and text will not look good and will not be easy to get by the user, and I also think we should never have established that mix of icons and text for the table column titles in the list view. It might have made sense when we had problems with space (width), but now as we can decide which columns to show or hide, that space problem is less critical. So I would still recommend to make that consistent on the long run, i.e. use text only or use icons only at both places, or maybe let the user adjust some setting to select if icons or text. Possibly inspired by the imagination I had on the (in my opinion) ugly look of the dropdown with a mix of icons and text, I had written "silly idea" in my comment. That was not really nice, and I honestly apologize for that and will try to avoid that in future. @chmst I hope you can accept my apologize. |
@brianteeman The "Ordering" column also doesn't have a text, only an icon. But yes, that's what I meant. |
Anyway, the main thing is that I made a mistake and that I have chosen wrong words and that I realized my mistakes and want to apologize. |
So I would say that the columns with just an icon should be updated to include text but I would not add the icon to the dropdown. As for the ordering column - I have no strong opinion |
Steps to reproduce the issue
Expected result
Actual result
System information (as much as possible)
Additional comments
Can be fixed with additional style:
.dropdown-menu li label { white-space: nowrap; }
The text was updated successfully, but these errors were encountered: