Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Column Width #38507

Merged
merged 4 commits into from
Sep 6, 2022
Merged

[4.2] Column Width #38507

merged 4 commits into from
Sep 6, 2022

Conversation

brianteeman
Copy link
Contributor

Changes the css classes for the dropdown column selector to remove text wrapping which is especially a problem in German but can also be seen in english in the category list view

Pull Request for Issue #38503 .

Testing Instructions

Either npm run build:js or install a prebuilt package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

Changes the css classes for the dropdown column selector to remove text wrapping
@sba
Copy link
Contributor

sba commented Aug 18, 2022

looks good to me. thanks @brianteeman !

@sandewt
Copy link
Contributor

sandewt commented Aug 18, 2022

I have tested this item ✅ successfully on e5421a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

@sandewt
Copy link
Contributor

sandewt commented Aug 18, 2022

Result test:

screen shot 2022-08-18 at 07 49 26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e5421a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 18, 2022
@alikon
Copy link
Contributor

alikon commented Aug 18, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@Quy Quy added the PR-4.2-dev label Aug 18, 2022
@heelc29
Copy link
Contributor

heelc29 commented Aug 22, 2022

@brianteeman Could the margin, at the bottom of the ul-element, be removed .mb-0?
image

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Aug 22, 2022
@brianteeman
Copy link
Contributor Author

Bottom margin removed as requested

@heelc29
Copy link
Contributor

heelc29 commented Aug 22, 2022

I have tested this item ✅ successfully on 30a9c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 30a9c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

@wilsonge wilsonge merged commit 8bb8794 into joomla:4.2-dev Sep 6, 2022
@wilsonge
Copy link
Contributor

wilsonge commented Sep 6, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@brianteeman brianteeman deleted the nowrap branch September 6, 2022 10:36
@brianteeman
Copy link
Contributor Author

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants