-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_categories] Coding standards xml + fix a wrong closing tag #10515
[com_categories] Coding standards xml + fix a wrong closing tag #10515
Conversation
Add empty line before opening tags for readability
hint="JFIELD_ALIAS_PLACEHOLDER" | ||
size="45"/> | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would put hint
after description
, because it's also a text var value.
doesn't exist in the coding standards, but makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to follow loading order of extra field attributes : https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/fields/text.php#L218
But i agree we could write a rule with all often used attributes: default
, class
, size
, hint
...
Here, no defined rules... So tried to keep form field rendering logical with HTML rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then
I have tested this item ✅ successfully on c63a85a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515. |
@andrepereiradasilva Thanks for testing! (maybe we could work on some extra code standards rules/recommendations? ;-) ) |
I have tested this item ✅ successfully on c63a85a However, I have spotted an issue related to the changes to modals recently done and which are already merged into the latest staging. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515. |
Thanks everybody |
Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tag, form xml files com_contact
Summary of Changes
categories.xml
models/forms/category.xml
tags
models/forms/filter_categories.xml
Testing Instructions