Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_categories] Coding standards xml + fix a wrong closing tag #10515

Merged
merged 3 commits into from
May 16, 2016

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented May 16, 2016

Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tag, form xml files com_contact

Summary of Changes

categories.xml

  • Remove extra empty lines at end of xml file

models/forms/category.xml

  • Code standards
  • Add emtpy line before each opening tag (readability)
  • Fix wrong field closing tag : tags

models/forms/filter_categories.xml

  • Code standards
  • Add emtpy line before each opening tag (readability)

Testing Instructions

  • code review
  • apply and test all is working as before

hint="JFIELD_ALIAS_PLACEHOLDER"
size="45"/>
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would put hint after description, because it's also a text var value.

doesn't exist in the coding standards, but makes sense to me.

Copy link
Contributor Author

@cyrezdev cyrezdev May 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to follow loading order of extra field attributes : https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/fields/text.php#L218
But i agree we could write a rule with all often used attributes: default, class, size, hint ...
Here, no defined rules... So tried to keep form field rendering logical with HTML rendering.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then

@cyrezdev cyrezdev changed the title Coding standards com categories xml [com_categories] Coding standards xml + fix a wrong closing tag May 16, 2016
@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on c63a85a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515.

@cyrezdev
Copy link
Contributor Author

@andrepereiradasilva Thanks for testing! (maybe we could work on some extra code standards rules/recommendations? ;-) )

@BurtNL
Copy link
Contributor

BurtNL commented May 16, 2016

I have tested this item ✅ successfully on c63a85a

I have tested Categories without the patch and with the patch applied.
I could not find differences, so successfully tested.

However, I have spotted an issue related to the changes to modals recently done and which are already merged into the latest staging.
@JoomliC: I will report the issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 16, 2016
@roland-d roland-d merged commit 2125659 into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@roland-d
Copy link
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants