Fix #10520 (issue with "Save & Close" in modal) + function to update input title when changed #10522

cyrezdev · 2016-05-17T00:48:36Z

Pull Request for Issue #10520.

Summary of Changes

Fix modal closing for already reviewed and refactoried edit modals.
Article and module Select and Edit modals will be reviewed soon with the same improvements and fixes as already merged for com_categories, com_newsfeeds and com_contact, and i will add then this patch in the same time of those upcoming PRs.
EDIT: add function to update input title when changed

Testing Instructions

Test with edit modal : newsfeed, contact and categories
Click on Save and Save & Close with a correct edition (no error), and then with an empty title, or any other possible error (not filled required field).
Expected behavior: If an error, Save & Close won't close the modal, and Save will never close the modal (close only when requested, and on successful edition)
More detailled testing intructions for reviewed modals here: Modal com_categories: improve Select & Edit Category #10441
EDIT: Edit a contact, news feed and/or category, change title, and save and close : this title in the input should be then updated with the new title.

BurtNL · 2016-05-17T08:48:21Z

I have tested this item ✅ successfully on 2e2af7c

Tested successfully on categories for articles, contacts and newsfeeds. Works as described. Great!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

infograf768 · 2016-05-17T09:18:44Z

Works OK for all categories.
The edit button is broken for contact and newsfeed individual items: it just does not load the modal anymore here.

cyrezdev · 2016-05-17T09:42:26Z

@infograf768 did you test on latest staging ?
As it is a fix for already merged changes, and contact and newsfeed were merged only yesterday (just before this issue report).

infograf768 · 2016-05-17T09:48:09Z

Sure, on latest staging

The error here comes from these changes:

-               . ' href="#contactEdit' . $this->id . 'Modal"'
+               . ' href="#contactEdit' . $this->value . 'Modal"'

and

        $html[] = JHtml::_(
            'bootstrap.renderModal',
-           'categoryEdit' . $this->id . 'Modal',
+           'categoryEdit' . $this->value . 'Modal',

After changing back to $this->id the modals load OK with an href of the type
#contactEditjform_associations_en_GBModal

andrepereiradasilva · 2016-05-17T09:48:15Z

hum, i had the exact same problem @infograf768 (and used the latest staging).

@JoomliC also, i notice a small detail not related to this PR.
Just letting you know in case you didn't notice.
When i change the category name from "Photo Gallery" to "Photo Gallery test" the category gets updated, ok. But, the category title in the zone where we have the "Select" "Edit" "Clear" doesn't get updated.

andrepereiradasilva · 2016-05-17T09:49:51Z

@JoomliC the "Edit" modals work on menu items, but not in associations.

cyrezdev · 2016-05-17T10:51:43Z

Ok i see!
I will update this PR in a few hours (have to go) but the reason is alias passed to the value, so adding (int) before $this->value will solve it.
I will do extra checking when back, to be sure ;-)

joomla-cms-bot · 2016-05-17T15:39:10Z

This PR has received new commits.

CC: @BurtNL

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

cyrezdev · 2016-05-17T15:41:07Z

@andrepereiradasilva @BurtNL @infograf768 PR updated and should work now with associations as well as in menus ;-)

@JoomliC also, i notice a small detail not related to this PR.
Just letting you know in case you didn't notice.
When i change the category name from "Photo Gallery" to "Photo Gallery test" the category gets updated, ok. But, the category title in the zone where we have the "Select" "Edit" "Clear" doesn't get updated.
image

@andrepereiradasilva Added too a new function for edit modal, to update the input title when changed ;-)
So to be tested too!

andrepereiradasilva · 2016-05-17T16:55:42Z

I have tested this item ✅ successfully on 2214bdc

Done tests in:

"Select" and "Edit" buttons in Single Contact and Single News feed menu item types.
"Select", "Edit" and "Clear" buttons in newsfeed, contact and category associations.

All worked without issues!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

infograf768 · 2016-05-18T07:29:41Z

I have tested this item ✅ successfully on 2214bdc

Works great now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

infograf768 · 2016-05-18T07:30:23Z

RTc. Thanks! Let's go on for the other modals. 😃

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

rdeutz · 2016-05-18T07:50:30Z

administrator/components/com_categories/models/fields/modal/category.php

+		{
+			$value = (int) $this->value;
+		}
+


Why so complicated?

$value = (int) $this->value;

if (0 == $value)
{
$value = '';
}

Doesn't this also work?

$value = (int) $this->value === 0 ? '' : $this->value;

But for me this is a detail.

@rdeutz i don't have change all existed code, but i agree that as i've simplify some, i can this one too!
Do you agree if i change for this one:
$value = (int) $this->value === 0 ? '' : (int) $this->value;
?

In fact, just updated, with a simplified of active id variable ;-)

andrepereiradasilva · 2016-05-18T11:06:06Z

@JoomliC,

So after this PR gets merged, reggarding modals, that i see there is, the main remaining modals (for 3.6.0?):

The latest changes also in Articles Edit/List modals
The latest changes also in Modules Edit/List modals
The same changes in Users List modal (if possible the "- No User -" option be in the modal buttons zone)

And the other less relevant modals (for 3.6.x or 3.7.0?):

Use the new viewport height/width in the finder index modal, messages my settings, the multilanguage status module modal, the user notes list modal, redirect bulk import modal, the batch modals and other similiar modals (if other exist).

And some ideas:

Converting the"Help" button popup up in a modal?
Dynamic viewport height/width in the TinyMCE "+Article" "+Module" buttons?

Is this right? Or do i miss something?

cyrezdev · 2016-05-18T11:31:52Z

@andrepereiradasilva You're right + a few minor improvement for com_template modals ;-)
First i will do priority update : article and module update (because of issues to fix)
Others will be much more cosmetic, consticency, and BS HTML structure standards

About Help, yes, good idea (for when i will have done others ;-) ) !
About TinyMCE, i don't know yet, as it's currently using TinyMCE modals (not Boostrap) which are not responsive. (not check yet, but think it could be possible to use BS modal instead of TinyMCE ones, as those 4 buttons are loaded by plugins.

joomla-cms-bot · 2016-05-18T11:39:21Z

This PR has received new commits.

CC: @andrepereiradasilva, @BurtNL, @infograf768

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

cyrezdev · 2016-05-18T11:42:56Z

@andrepereiradasilva @rdeutz @infograf768 @BurtNL I have updated the PR, by simplifying the active id $value control (as well commented by @rdeutz 👍 ) :

Remove if / else
Set empty only if active id is > 0 (do not allow negative id)
Use $value in title query request instead of (int) $this->value > 0 as now, with my changes in this PR, the $value variable is set before.

Could review/test again ?
Thanks!

andrepereiradasilva · 2016-05-18T11:58:46Z

I have tested this item ✅ successfully on 29a6bf9

works fine

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

cyrezdev · 2016-05-19T11:05:29Z

Even if this PR to fix newsfeeds, categories and contacts Select & Edit modals is not merged, i have created the PR for Article Select and Edit Modals with same fixes and updates applied here ;-)
#10557

infograf768 · 2016-05-20T06:55:10Z

I have tested this item ✅ successfully on 29a6bf9

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

roland-d · 2016-05-20T09:42:12Z

I have tested this item 🔴 unsuccessfully on 29a6bf9

@JoomliC I am marking this as not tested successfully because I am not sure if this is part of this PR or a separate issue but this catches your attention :)

When I go to Newsfeed (or Articles) and edit an item go to the Images tab, click on the Select for the first image. This brings up the image modal. Clicking the X in the corner works fine but the Cancel button doesn't do anything. I would expect the modal to close here.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

roland-d · 2016-05-20T09:42:48Z

Removing RTC for now as there is an unsuccessful test.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10522.}

infograf768 · 2016-05-20T09:53:14Z

@roland-d
I think you found another bug (which I confirm) unrelated to the purpose of this PR.

cyrezdev · 2016-05-20T11:12:45Z

@roland-d I will check it in another PR, as not related to this PR. But well found! 👍
And... the issue is already there in stable 3.5.1 !
So, will check this today ;-)

But you can set RTC again here ;-)

roland-d · 2016-05-20T12:07:54Z

@JoomliC Thank you for checking, will move this forward.

roland-d · 2016-05-20T12:08:11Z

Thanks everybody

cyrezdev · 2016-05-20T15:49:14Z

@roland-d : PR done to fix "Cancel" button in image modal : #10564
;-)

cyrezdev added 4 commits May 17, 2016 02:21

Fix category edit modal (issue joomla#10520)

121e5ba

Fix category edit modal (issue joomla#10520)

2165d63

Fix contact edit modal (issue joomla#10520)

4897400

Fix news feed edit modal (issue joomla#10520)

2e2af7c

joomla-cms-bot added the PR-staging label May 17, 2016

cyrezdev mentioned this pull request May 17, 2016

Can save Article or Category without valid name in modal view #10520

Closed

Fix associations + Add function to update input title when changed

2214bdc

cyrezdev changed the title ~~Fix #10520 (issue with "Save & Close" in modal)~~ Fix #10520 (issue with "Save & Close" in modal) + function to update input title when changed May 17, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 18, 2016

brianteeman added this to the Joomla 3.6.0 milestone May 18, 2016

rdeutz reviewed May 18, 2016
View reviewed changes

Simplify active id $value control

29a6bf9

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 20, 2016

roland-d merged commit 9277f9c into joomla:staging May 20, 2016

cyrezdev mentioned this pull request May 20, 2016

Fix "Cancel" button not closing modal images #10564

Merged

infograf768 mentioned this pull request May 21, 2016

RTL: Align correctly the modal footer buttons #10569

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #10520 (issue with "Save & Close" in modal) + function to update input title when changed #10522

Fix #10520 (issue with "Save & Close" in modal) + function to update input title when changed #10522

cyrezdev commented May 17, 2016 •

edited by joomla-cms-bot

Loading

BurtNL commented May 17, 2016

infograf768 commented May 17, 2016

cyrezdev commented May 17, 2016 •

edited

Loading

infograf768 commented May 17, 2016

andrepereiradasilva commented May 17, 2016 •

edited

Loading

andrepereiradasilva commented May 17, 2016

cyrezdev commented May 17, 2016

joomla-cms-bot commented May 17, 2016

cyrezdev commented May 17, 2016

andrepereiradasilva commented May 17, 2016

infograf768 commented May 18, 2016

infograf768 commented May 18, 2016

rdeutz May 18, 2016

andrepereiradasilva May 18, 2016 •

edited

Loading

cyrezdev May 18, 2016

cyrezdev May 18, 2016

andrepereiradasilva commented May 18, 2016 •

edited

Loading

cyrezdev commented May 18, 2016

joomla-cms-bot commented May 18, 2016

cyrezdev commented May 18, 2016

andrepereiradasilva commented May 18, 2016

cyrezdev commented May 19, 2016

infograf768 commented May 20, 2016

roland-d commented May 20, 2016

roland-d commented May 20, 2016

infograf768 commented May 20, 2016

cyrezdev commented May 20, 2016

roland-d commented May 20, 2016

roland-d commented May 20, 2016

cyrezdev commented May 20, 2016

Fix #10520 (issue with "Save & Close" in modal) + function to update input title when changed #10522

Fix #10520 (issue with "Save & Close" in modal) + function to update input title when changed #10522

Conversation

cyrezdev commented May 17, 2016 • edited by joomla-cms-bot Loading

Summary of Changes

Testing Instructions

BurtNL commented May 17, 2016

infograf768 commented May 17, 2016

cyrezdev commented May 17, 2016 • edited Loading

infograf768 commented May 17, 2016

andrepereiradasilva commented May 17, 2016 • edited Loading

andrepereiradasilva commented May 17, 2016

cyrezdev commented May 17, 2016

joomla-cms-bot commented May 17, 2016

cyrezdev commented May 17, 2016

andrepereiradasilva commented May 17, 2016

infograf768 commented May 18, 2016

infograf768 commented May 18, 2016

rdeutz May 18, 2016

Choose a reason for hiding this comment

andrepereiradasilva May 18, 2016 • edited Loading

Choose a reason for hiding this comment

cyrezdev May 18, 2016

Choose a reason for hiding this comment

cyrezdev May 18, 2016

Choose a reason for hiding this comment

andrepereiradasilva commented May 18, 2016 • edited Loading

cyrezdev commented May 18, 2016

joomla-cms-bot commented May 18, 2016

cyrezdev commented May 18, 2016

andrepereiradasilva commented May 18, 2016

cyrezdev commented May 19, 2016

infograf768 commented May 20, 2016

roland-d commented May 20, 2016

roland-d commented May 20, 2016

infograf768 commented May 20, 2016

cyrezdev commented May 20, 2016

roland-d commented May 20, 2016

roland-d commented May 20, 2016

cyrezdev commented May 20, 2016

cyrezdev commented May 17, 2016 •

edited by joomla-cms-bot

Loading

cyrezdev commented May 17, 2016 •

edited

Loading

andrepereiradasilva commented May 17, 2016 •

edited

Loading

andrepereiradasilva May 18, 2016 •

edited

Loading

andrepereiradasilva commented May 18, 2016 •

edited

Loading