Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_newsfeeds] Coding standards form xml + correction wrong closing tags #10535

Merged
merged 4 commits into from
May 17, 2016

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented May 17, 2016

Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tags, form xml files com_newsfeeds

Summary of Changes

config.xml

  • Code standards
  • Add emtpy line before each opening tag (readability)
  • Fix mix space/tabs for a few indents

newsfeeds.xml

  • Remove extra empty line at end of xml file

models/forms/newsfeed.xml

  • Code standards
  • Add emtpy line before each opening tag (readability)
  • Fix wrong field closing tags : catid & tags

models/forms/filter_newsfeeds.xml

  • Add emtpy line before each opening tag (readability)

Testing Instructions

  • code review
  • apply and test all is working as before

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on d3e1309

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10535.

@wilsonge wilsonge merged commit 7fc84e3 into joomla:staging May 17, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants