Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading iframe in modal (issue reported here https://github.com/j… #10560

Merged
merged 1 commit into from
May 21, 2016

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented May 20, 2016

Pull Request for Issue reported by @roland-d : #10557 (comment).

When I click the Edit button the modal comes up and I first see the article list which then changes to the edit page.
Why is the article list shown before the edit screen? I would expect the edit screen without seeing the article list first.

Summary of Changes

  • When an iframe is loaded inside a modal, this one is destroyed first and then reloaded to use then Jlayout modal iframe, but it could return the issue reported (see Testing Instructions before patch, or @roland-d comment above) when the script is included in modal event handler "shown".
  • Adding the iframe rendering inside a "show" event (before the modal has been made visible to the user), solves this issue.

Testing Instructions

Before Patch:

  • Open any Edit modal (article, category, module, contact, newsfeed) : can be found in menu item type "Single ****" or in association tab of article, category, newsfeed, contact edit page
  • After click on "Edit" button (the layout loads directly) click on "Close"
  • Then click again on "Edit" button, and you may see the list view 1/2 second before the edit layout loads.

After Patch:

  • Do the same: the edit layout loads each time directly, and the list (contacts, articles...) does not show up anymore before edit view

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 6ded0a7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10560.

@pete-rossetti
Copy link

Yup have tested this patch successfully - the delay in filling the modal is removed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10560.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10560.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 21, 2016
@roland-d roland-d merged commit 6691e8e into joomla:staging May 21, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 21, 2016
@zero-24
Copy link
Contributor

zero-24 commented May 22, 2016

@brianteeman @roland-d can we get the milestone here?

@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 22, 2016
@brianteeman
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants