-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal com_modules/com_menus: improve Edit Module (+ fix old issues) #10566
Modal com_modules/com_menus: improve Edit Module (+ fix old issues) #10566
Conversation
this works all great! |
@andrepereiradasilva Yes, exactly, it will be another PR! |
I have tested this item ✅ successfully on cf4c7aa This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
@andrepereiradasilva in fact, i will update this one, with Menus > Manage dropdown and "Add a module to this menu" (you're right, as this PR not merged, would be better to do this in the same time, and too, i have applied some extra-changes because of the Add module ;-) ) |
ok |
This PR has received new commits. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
@andrepereiradasilva Now ready 👍 |
you have conflicts |
This PR has received new commits. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
Thanks @andrepereiradasilva ! |
I have tested this item ✅ successfully on 127542e When you will do the css for modal-header, you have to set it to LTR: text-align:left; RTL: text-align:right; And not as you tried in the reverted part for the header. 😃 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
Hmm, tested OK on issues. Does not always show here. |
See https://status.github.com/ This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
@infograf768 Thanks for testing! And for modal header alignment fix, PR is opened : #10607 |
I have tested this item ✅ successfully on 127542e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
rtc. thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10566. |
Thanks for testing! |
@JoomliC while investigating the origin of #10556 i notice that mootools!! is loaded in the global config... Investigating a little more i found mootools is loaded because the tooltips and modal (Squeezebox) of the image selector. It seems this one is a remaining from the mootools still in use somehow ... Since you are doing all this great work on the modals and tooltips, i remembered to ask you this: do you thing it's possible to replace this mootools modal/toolip by bootstrap modal/toolip? The media select field is generated in this file: https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/form/field/media.php |
@andrepereiradasilva It was what @dgt41 did in 3.5.0-RC, but was reverted just before release because of B/C issue with the media field modal. |
ok thanks . wasn't aware of that "history". |
Thanks everybody |
Improve modal to Add and Edit a module. (+ patch PR 10522)
Note: to be testing on staging.
Summary of Changes
Save
(keep modal open),Save & Close
andClose
button to the footer of the modalTesting Instructions (Staging)
Menus
>Add new menu item
>Module Assignment
tab.EDIT:
Additional tests after update :
Menus
>Manage
Same rendering as for Categories in PR #10441 (screenshots)