mod_menu invalid rendering of items of type alias and url #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please create a tracker on joomlacode |
|
Unfortunately just reverting will simply recreate the security issue of allowing dangerous strings to be saved. |
|
I'm confused, either the string is double encoded or not. If it was encoded before there shouldn't have been an issue. This doesn't make sense to me. |
|
Corrected through new patch in tracker |
wilsonge
pushed a commit
that referenced
this pull request
Jun 4, 2017
* Check the folder name the same way as with files * The model should return the name of the created file
bembelimen
referenced
this pull request
in bembelimen/joomla-cms
Apr 26, 2018
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 3, 2020
chmst
pushed a commit
to chmst/joomla-cms
that referenced
this pull request
May 26, 2020
hans2103
pushed a commit
to hans2103/joomla-cms
that referenced
this pull request
Oct 5, 2020
…#107--pagination-remove-borders Remove the white border on active pagination elements
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
obuisard
pushed a commit
to obuisard/joomla-cms
that referenced
this pull request
Feb 21, 2023
DB Table name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Joomla 2.5 mod_menu rendering of menu items of type alias and url calls htmlspecialchars for item url.
But this is already processed by helper of mod%menu by calling JRoute::_() function. It results in invalid urls.