-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactory com_banners tracks export modal + new toolbar button layout #10934
Conversation
@JoomliC Thanks for fixing tooptip issue. |
I have tested this item ✅ successfully on 215efce This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
Thanks @RonakParmar for feedback! But, if an issue with scrolling, should be related to this one (dynamically add of scrolling): #9817 So, could you attached a screenshot of issue, as well as some information: screnn size, browser and its version, OS ? Thanks! |
Here is my system information as much as possible: Joomla! Version : Joomla! 3.6.0-beta2 Beta [ Noether ] 16-June-2016 13:54 GMT This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
@RonakParmar you screen shot shows no issue in scrolling (i mean it works as expected, and that's good!). @brianteeman does 50vh height was ok for you in Isis test of this PR ? (or a 60vh height could be better: https://github.com/joomla/joomla-cms/pull/10934/files#diff-4b21245c193bec415dbe082fd9486de3R96 ?) |
After applying the PR it looks fine to me |
It's a standard view of my device, I do not change my screen size. |
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
Thanks @brianteeman ! I have just updated a little the PR by not using viewport height which may not change a bit for you, and then works too for @RonakParmar's screen size ;-) @RonakParmar Thanks for screen size! Could you test back this PR with this minor adjustment, thanks! |
I have tested this item ✅ successfully on 5340062 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
I have tested this item ✅ successfully on 5340062 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
I have tested this item ✅ successfully on 5340062 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
Thanks everybody for testing 👍 |
rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934. |
@joomla-cms-bot please let me know if you have holiday too than we can take that tasks 🌴 |
Pull Request for Issue #10911 & PR #10927 (improve it).
Summary of Changes
Download Tracks Modal:
renderField
)note
forFile Name
description in a alert-info style.Compressed
label (prevent tooltip cropped at top when in iframe)New Generic Toolbar Button Layout:
Testing Instructions
To be tested on staging or 3.6.0-beta
Export
toolbar buttonCancel
andExport
buttons now in modal footerIsis admin template
Before:
After:
Hathor admin template
Before:
After: