[#28003] Multidb install #122
Conversation
Conflicts: installation/helpers/database.php installation/models/configuration.php installation/models/database.php installation/views/database/view.html.php
|
Do we have a tracker? |
|
Apologies: It's #28003 |
| * @package Joomla.Libraries | ||
| * @since ¿ | ||
| */ | ||
| class JDatabaseInstallerException extends Exception |
There was a problem hiding this comment.
The platform is moving away from these non-semantic exceptions. I don't think the CMS should start with them.
There was a problem hiding this comment.
Do we have any documentation or guidelines on this ?
|
Could you explain why you made this a library? I see no usefulness beyond the installation for this kinda stuff. I'd just put it into the installation folder. |
|
I can imagine the possibility to migrate the database from one engine to another. So the code would be used to check and setup the database for the new engine. |
|
So, this might be closed after six month without attention, or is there anything that is missing ? |
|
Thanks for coding this, Nikolai! Could you update the pull request since it's out of sync? Once it's updated, please leave a message on here and I'll get a reviewer to review it for you and provide feedback on your questions. Thanks! :) |
|
I'm closing this as it's not mergeable and 2 years old. Feel free to open if you update it and are still interested in get it merged. Thanks for contributing. |
* Use JForm to render the action plugins * Only determine the with and height when it is a file * Updates * Add demo crop plugin * Introduce an event bus to activate and deactivate a plugin n the js side * Not needed * Valid HTML * Localizing the plugins * Move to plugin layouts * New lines * Add rotate plugin * Add rotate plugin * Remove not needed code
Fix in the RoboFile in the env parameter
Use plurals for the sidebar
* Replaced tour with guidedtours in plugin test * Renamed onAjax function * Error assigning step id * Steps never get to complete button Error progress indicator current step * Added aria-label on step buttons * attachTo unnecessary for start tour step
This modifies the installation process to allow database specific checks, like version etc.