com_search on back-end: Results links opens in backend window instead of new Tab #12626
Conversation
* handeling for mcrypt and openssl * Language changes suggested bei Brian
|
Hmm look like you have mixed commits here? |
* handeling for mcrypt and openssl * Language changes suggested bei Brian (reverted from commit 08d6728)
|
@zero-24 ooops - quick and dirty fix to the PR - should be ok now |
|
Do you want to hard code the english text? |
|
No - oops |
| <a class="badge <?php if ($item->returns > 0) echo "badge-success"; ?>" href="<?php echo JUri::root(); ?>index.php?option=com_search&view=search&searchword=<?php echo JFilterOutput::stringURLSafe($item->search_term); ?>"> | ||
| <?php echo $item->returns; ?></a> | ||
| <a class="badge <?php if ($item->returns > 0) echo "badge-success"; ?>" target="_blank" href="<?php echo JUri::root(); ?>index.php?option=com_search&view=search&searchword=<?php echo JFilterOutput::stringURLSafe($item->search_term); ?>"> | ||
| <?php echo $item->returns; ?><span class="icon-out-2"><span class="element-invisible"><?php echo JText::_('JBROWSERTARGET_NEW'); ?></span></span></a> |
There was a problem hiding this comment.
please don't use two spans . i think you could use just
<span class="icon-out-2 element-invisible"><?php echo JText::_('JBROWSERTARGET_NEW'); ?></span>There was a problem hiding this comment.
That doesnt work
|
Ok I will check. That's how we do it elsewhere - nut doesn't mean it's
correct :)
|
|
I have tested this item ✅ successfully on 0b78918 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12626. |
|
I have tested this item ✅ successfully on 0b78918 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12626. |
|
@brianteeman can we RTC or do you want to change something here? |
|
Its fine for merging from my perspective. The suggestion from Andre did not
work.
|
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12626. |
|
Thanks |
… of new Tab (joomla#12626) * Updated installation language files * 2fa handeling for mcrypt and openssl (joomla#12497) * handeling for mcrypt and openssl * Language changes suggested bei Brian * search results in new window * 2fa handeling for mcrypt and openssl (joomla#12497) * handeling for mcrypt and openssl * Language changes suggested bei Brian (reverted from commit 08d6728) * Updated installation language files (reverted from commit e504f71) * language string
Pull Request for Issue #11852 .
Summary of Changes
In the list of search results the link to the search now opens in a new window
An icon is added to visually indicate that it is opening in a new window and a screen reader only text link is also present.
Testing Instructions
Enable search results in the admin search component
Perform a few searches in the front end
Return to the search component in the admin and you will see the log of the searched terms.
The number at the end of the row is the number of times that the term has been searched for.
Click on the link and it will open in a new window/tab