-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move weblinks stats to weblinks repo #13389
Conversation
I have tested this item ✅ successfully on 6a767e3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389. |
I have tested this item 🔴 unsuccessfully on 6a767e3
|
@franz-wohlkoenig Looks like you might have tried to apply #288 using the patch tester? That won't work because the PR includes a change to the update server manifest to cater for the addition of a new system plugin, but that file is actually not part of the extension package. You need to build the extension package by following the instructions in the README.md and install it using the Joomla extension installer. If you have trouble building the package, drop me a line and I'll send you a pre-built package with PR 288 included. |
@chrisdavenport You are right, i had tried apply #288 by changing Repository of Patchtester. Thanks for Information about building a extension package by my own – i will try it. If i have no success, i write for you're pre-built package. |
@chrisdavenport Can you please send the pre-built package? |
@franz-wohlkoenig Pre Built package with weblinks PR joomla-extensions/weblinks#288. |
I have tested this item ✅ successfully on 6a767e3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389. |
I have tested this item ✅ successfully on 6a767e3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389. @chrisdavenport @yvesh – thanks for helping |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389. |
In joomla#13389 the code for weblinks in the stats module was rempved but the description remains in the module. This is confusing and so this PR removess the text about weblinks from the description. Its not needed just as there is no text in the description about having plugins installedd that will inject other stats into that module
* Complete the removal of weblinks from stats modules In #13389 the code for weblinks in the stats module was rempved but the description remains in the module. This is confusing and so this PR removess the text about weblinks from the description. Its not needed just as there is no text in the description about having plugins installedd that will inject other stats into that module * update * sloppy * less haste more speed
Pull Request for Issue #13386 .
Summary of Changes
Move web links statistics shown on the admin control panel from Joomla core to a system plugin in the web links package.
Testing Instructions
Documentation Changes Required
None?