Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move weblinks stats to weblinks repo #13389

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

chrisdavenport
Copy link
Contributor

@chrisdavenport chrisdavenport commented Dec 28, 2016

Pull Request for Issue #13386 .

Summary of Changes

Move web links statistics shown on the admin control panel from Joomla core to a system plugin in the web links package.

Testing Instructions

Documentation Changes Required

None?

@alikon
Copy link
Contributor

alikon commented Dec 29, 2016

I have tested this item ✅ successfully on 6a767e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389.

@ghost
Copy link

ghost commented Dec 29, 2016

I have tested this item 🔴 unsuccessfully on 6a767e3

- Apply 13389 (Joomla! CMS): No Weblinks are shown in [mod_admin_stats]

@chrisdavenport
Copy link
Contributor Author

@franz-wohlkoenig Looks like you might have tried to apply #288 using the patch tester? That won't work because the PR includes a change to the update server manifest to cater for the addition of a new system plugin, but that file is actually not part of the extension package. You need to build the extension package by following the instructions in the README.md and install it using the Joomla extension installer. If you have trouble building the package, drop me a line and I'll send you a pre-built package with PR 288 included.

@ghost
Copy link

ghost commented Dec 30, 2016

@chrisdavenport You are right, i had tried apply #288 by changing Repository of Patchtester. Thanks for Information about building a extension package by my own – i will try it. If i have no success, i write for you're pre-built package.

@ghost
Copy link

ghost commented Dec 30, 2016

@chrisdavenport Can you please send the pre-built package?

@yvesh
Copy link
Member

yvesh commented Dec 30, 2016

@franz-wohlkoenig Pre Built package with weblinks PR joomla-extensions/weblinks#288.
pkg-weblinks-3.6.0-beta.zip

@yvesh
Copy link
Member

yvesh commented Dec 30, 2016

I have tested this item ✅ successfully on 6a767e3

Works as expected

screenshot 2016-12-30 09 17 51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389.

@ghost
Copy link

ghost commented Dec 30, 2016

I have tested this item ✅ successfully on 6a767e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389.
@chrisdavenport @yvesh – thanks for helping

@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Dec 30, 2016
@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13389.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 30, 2016
@rdeutz rdeutz merged commit ee12fd8 into joomla:staging Jan 2, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 2, 2017
@chrisdavenport chrisdavenport deleted the move-weblinks-stats branch January 2, 2017 01:02
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Aug 9, 2017
In joomla#13389 the code for weblinks in the stats module was rempved but the description remains in the module. This is confusing and so this PR removess the text about weblinks from the description. Its not needed just as there is no text in the description about having plugins installedd that will inject other stats into that module
zero-24 pushed a commit that referenced this pull request Aug 13, 2017
* Complete the removal of weblinks from stats modules

In #13389 the code for weblinks in the stats module was rempved but the description remains in the module. This is confusing and so this PR removess the text about weblinks from the description. Its not needed just as there is no text in the description about having plugins installedd that will inject other stats into that module

* update

* sloppy

* less haste more speed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants