[namespace] Move disptacher to namespace

[laoneo]

The disptacher functionality introduced with #13687 as namespaced version.

[wilsonge]

There's no need for these extra properties. $app->getUser() will return the user object, and $app->getLanguage will get the language object

[wilsonge]

You are also missing these properties when you create the class in JComponentHelper so banners is now fatal erroring.

[laoneo]

getUser() is not available

[wilsonge]

Apologies I meant getIdentity() (which comes from https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Cms/Application/IdentityAware.php)

[wilsonge]

👍 for namespacing - but your modifications are wrong :)

[joomdonation]

Could I ask why $app is private? What if in component dispatcher (like in BannersDispatcher class) we need to access to app object ? Maybe it should be protected instead of private?

[laoneo]

I would even pass the app as argument to the dispatch function. But don't know why it was decided as a constructor argument, so I left it as it was made in the original PR.

[wilsonge]

Originally because I was going to load language files in the constructor. But @mbabker objected. So there's no good reason. But it probably does belong here anyhow, so extensions doing any other logic can do thing in the constructor

But @joomdonation is right it should have been protected

[laoneo]

My last commit is using the user and language from the app and making the app available trough getApplication().

[wilsonge]

👍

[wilsonge]

Why are we remove the state here?

[laoneo]

As I was testing to install DPCalendar I got an error that $state needs to be public. It is already set up in the base class, so no need to do it here again, that's why I removed it here. It's a bug fix.

[wilsonge]

This isn't a new property in 4.x. This needs to go back into staging if it's a bug. Or at least put it into a separate PR. Let's keep PR's single responsibility

[laoneo]

This is introduced in 4 https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_installer/views/default/view.php#L25 and not available in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/views/default/view.php.

[wilsonge]

Right then that comes from this #12173 let's open up a separate issue for that. Because that's totally unrelated to dispatcher and so let's handle it in a separate PR.

[laoneo]

Done with #13980.

[wilsonge]

If you can remove this com_installer code i guess you accidently committed this is good to go

[laoneo]

Reverted the change. Will do a pr with the cleanup.

[wilsonge]

👍