Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Disable the option to show the user field on the front #14500

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 11, 2017

Pull Request for Issue #13873.

Summary of Changes

The user form field doesn't work on the front. Why is not part of this pr. This pr removes the option to define where the field to display.
image

Testing Instructions

  • Create a new user field.
  • Open the options tab.

Expected result

The "Show On" setting should not being displayed.

Actual result

The "Show On" setting is displayed.

Documentation Changes Required

@brianteeman
Copy link
Contributor

Thank you

@ghost
Copy link

ghost commented Mar 11, 2017

I have tested this item 🔴 unsuccessfully on 0d3897e

"Shown On" is shown at User- and Artices-Field (PR-Title ist about User, Screenshot about Articles).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

@laoneo
Copy link
Member Author

laoneo commented Mar 12, 2017

It's about the "User" custom field. Did you create a user custom field?

@PhilETaylor

This comment was marked as abuse.

@ghost
Copy link

ghost commented Mar 12, 2017

@laoneo Created a New Field and Shown on is shown in Tab Options.

@laoneo
Copy link
Member Author

laoneo commented Mar 12, 2017

@franz-wohlkoenig Is it really a user field?
image

@PhilETaylor there is some documentation already https://docs.joomla.org/J3.x:Adding_custom_fields/User_Field. The purpose of the field is to select a user. It is not too much complicated.

@ghost
Copy link

ghost commented Mar 12, 2017

I have tested this item ✅ successfully on 0d3897e

My brain told me till now "User Group" … sorry and thanks for hint, @laoneo


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

@mbabker
Copy link
Contributor

mbabker commented Mar 12, 2017

JFormFieldUser cannot be used on the frontend due to a hardcoded dependency in the layout to the com_users backend component (why the hell are library classes still hardcoded to depend on components!?). Until a proper proxy is in place for the support to happen, this PR is valid and should be merged.

Let's leave comments about architecture or design docs out of this for the moment.

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Mar 12, 2017

You can either write the support for the frontend com_users component required to use JFormFieldUser in a frontend edit context (this limitation is not new to the addition of com_fields, all that did was further expose the architectural flaw) or you can remove from the UI a misleading and unusable option. The latter is a better choice unless someone has a PR for the former ready in the next couple of days. Even then, this PR could easily be reverted as part of that one.

@ghost
Copy link

ghost commented Mar 17, 2017

If custom field is added in the backend with option "required", then adding an article in frontend at the moment (beta 3) becomes impossible because on submit we get en error message "Warning Field required: NameOfField"

@laoneo
Copy link
Member Author

laoneo commented Mar 17, 2017

@ysrostov can you please open a new issue for your problem. This will also happen when you set that setting to back end only and try to edit an article in the front. We need to decide what we should do in that situation. Thanks.

@ghost
Copy link

ghost commented Mar 17, 2017

Sure thing
#14692

@normanmm
Copy link

I have tested this item ✅ successfully on 0d3897e

Result is as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 23, 2017
@PhilETaylor

This comment was marked as abuse.

@zero-24 zero-24 modified the milestone: Joomla 3.7.0 Mar 29, 2017
@rdeutz rdeutz merged commit c591b34 into joomla:staging Mar 30, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Mar 30, 2017
@laoneo laoneo deleted the cf/user-front-disable branch March 31, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants