Select or Create in Menu #14637
Merged
Select or Create in Menu #14637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 43cf3cb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14637. |
1 similar comment
|
I have tested this item ✅ successfully on 43cf3cb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14637. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14637. |
wilsonge
requested changes
Mar 15, 2017
| @@ -305,7 +305,7 @@ JGLOBAL_CATEGORY_ORDER_DESC="The order that categories will show in." | |||
| JGLOBAL_CATEGORY_ORDER_LABEL="Category Order" | |||
| JGLOBAL_CENTER="Center" | |||
| JGLOBAL_CHECK_ALL="Check All" | |||
| JGLOBAL_CHOOSE_CATEGORY_DESC="Choose a category from the list." | |||
| JGLOBAL_CHOOSE_CATEGORY_DESC="Select or create a category to be displayed." | |||
There was a problem hiding this comment.
OK Two things here:
- You have a double space beween "select" and "or"
- Given this is in the global file and people may not have the create category option enabled do we feel comfortable that this isn't against b/c?
|
this PR have no Milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We now have the great ability to create an article, contact, category directly at the point you create a menu item. This PR updates the tooltip displayed to reflect that you can Select AND create. I also took the opportunity to standardise the strings across the component for consistency
Testing Instructions
On review or by checking the tooltips when creating menu items
