-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] New Frontend (Aurora) Template #14864
Conversation
Best news of the...... (can't remember) |
@MATsxm On the subject of copyright images... can https://unsplash.com/ be used (CC0) ? |
CC0 is compatible with GPL |
@ciar4n @wilsonge it is but it is nearly a question without answers as legal requirements may vary according to the copyright in the country of the photographer, which is very often forgotten. |
When a photographer uploads their photo to a site, they are agreeing to the license stated by the site. And the site specifically says
Either way, it's no big issue, it's only a banner. I'm sure the design team can come up with something that fits the bill |
I'm sure @MATsxm can take a lovely photo for us that he can donate to the project ;) |
@brianteeman - yes, a11y will be done afterwards, once the entire template is finished. I'd preferably like to get a beta of this merged so it's just there with the rest of core for people to use and test on the fly |
templates/aurora/index.php
Outdated
@@ -9,10 +9,7 @@ | |||
|
|||
defined('_JEXEC') or die; | |||
|
|||
/** @var JDocumentHtml $this */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add that comment back please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
my suggestion for chrome / module sizing is a variant of what we currently have.. |
About the mentioned module positions, e.g. As module positions are mainly exposed to developers/implementors, I think this would actually prevent confusion (rather than add to it). |
@born2webdesign i agree that the positions should have semantic meaning and I already commented on that earlier today regarding an ID but in this case an RTL language would not change anything. An RTL template is not a mirror of an LTR template so right is still right etc |
@brianteeman True, RTL doesn't have to be a mirror of LTR—that's why I agree there could also be |
In an admin template the ui should indeed be reversed/mirrored so you would be 100% correct there but we are talking about a frontend template here so left would still be left |
I was talking about the frontend, as well. See my example from above—it is not uncommon for a module to be displayed on the left in ltr and on the right in rtl. And with distinct positions ( |
in that scenario the correct way would be using the module assignment option already available. as this is a frontend template you can always create the positions and css as you want in your own template |
Sure, but if we are introducing sensible module positions, it would be nice to harmonise those with my own template's positions (that came out wrong, I meant changing my own template positions). |
I could just use |
My previous concern (changing sides (or not) for ltr-rtl) is mostly taken care of by assigning modules to the appropriate positions (as brought up by Brian). |
Yes it would be nice but sadly template developers like to reinvent the wheel. |
It's not reinventing the wheel at all. It's using proper naming conventions that SHOULD have been done in the first place, rather that The new positions mean the user no longer needs to get a template preview open to know where to assign modules. If the user has Protostar as their default template, then we can simply migrate the module positions over to the Aurora positions, so the the upgrade from 3.x to 4.0 is smooth. |
I was referring to 3pd template developers not core. ;) The reason that template positions have a "translation" was so that position-7 would never change in the code but the developer could give it a meaningful name in their own template - no one used it though |
Maybe we should stick with the generic but flexible position names but promote their translations more/make them more prominent? |
Really not sure what more we can do to encourage their use. Remember they also allow a position to be called left and gauche (french) so that in itself should be a reason to use them as it means the position is easy to understand in languages other than english |
First, we could give them even more descriptive names ("Left Sidebar", "Left Content" instead of just "Left"). |
I have read a little the story. |
Summary of Changes
So long Protostar and welcome Aurora, the new J4 template based on BS4.
As it currently stands, there are still more views to migrated over to BS4.
Aurora now uses proper naming conventions for module positions, such as
sidebar-left
,top-a
, etc.. unlike the oldposition-7
which nobody had any clue about.With the sample data, I've tried to make the homepage look like a proper demo site, by displaying a full stack of modules, each using different "Module Style" and "Moulde Class Suffix", to show new users what it has to offer out the box.
The banner image used if just for demo purposes until the design team provide something a bit more concrete.
Screenshot