Move and namespaces legacy fields #17322
Conversation
| @@ -82,7 +86,7 @@ protected function getOptions() | |||
| * unless the item is already in that category. | |||
| * Unset the option if the user isn't authorised for it. In this field assets are always categories. | |||
| */ | |||
| if ($user->authorise('core.create', $extension . '.category.' . $option->value) === false) | |||
| if ($user->authorise('core.create', $extension . '.category.' . $option->value) != true) | |||
|
Do we want the category form field to be moved into the category component rather than being a library form field? |
| use Joomla\CMS\Factory; | ||
| use Joomla\CMS\Form\Form; | ||
| use Joomla\CMS\Form\FormField; | ||
| use Joomla\CMS\Filesystem\Folder; |
There was a problem hiding this comment.
These haven't been namespaced yet
| use Joomla\CMS\Factory; | ||
| use Joomla\CMS\Form\Form; | ||
| use Joomla\CMS\Form\FormField; | ||
| use Joomla\CMS\Filesystem\Folder; |
joomla-cms-bot
changed the title
|
Status is set on "Needs Review". |
|
Should I do same thing but for 3.9 branch and close this PR? |
ghost
added
the
|
@wilsonge Close PR? |
| * | ||
| * @copyright Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| * @copyright Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| * | ||
| * @copyright Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| * @copyright Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| * | ||
| * @copyright Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| * @copyright Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Sorry that it has taken so long to respond to this pull request. We did this change in Joomla 4 already and wont move the files in Joomla 3. So I'm closing this pr. Nevertheless we would like to thank you for your contribution. |
Summary of Changes
This change move legacy form fields to Joomla\CMS\Form\Field directory for namespaces
Testing Instructions
Use Category , ComponentLayout or ModuleLayout form field and should work as usual
Expected result
Work as usual