[#17744] - Pressing clear button of calendar on required date field submits admin form in Joomla! 3.7.5 --- corrected #17793
Conversation
[#17729] - Color of the error message after attempting to delete a Admin-menu - SOLVED Changed 'alert-success' to 'alert-danger' in line 14
Updating My Repo
Updating Repo 31st Aug
Corrected the functionality of clear button in the finish publishing date in the article setting.
changed calender.min.js to calendar.js as this is where I have made changes.
media/system/js/fields/calendar.js
Outdated
| if (!this.inputField.hasAttribute('required')) { | ||
| var savea = row.querySelector('[data-action="clear"]'); | ||
| savea.addEventListener("click", function (e) { | ||
| if (1) { |
There was a problem hiding this comment.
Why we don't need to check for the required attribute? And why if (1)?
There was a problem hiding this comment.
@akritianand IMHO, the clear button should be hidden when field is required.
There was a problem hiding this comment.
Okay, if that is required, then there was not any problem initially. Because the clear button still showed up if the field was required; it just did not perform its function.
|
@akritianand You need to generate the |
| @@ -100,7 +100,7 @@ | |||
| // The static assets for the calendar | |||
| JHtml::_('script', $localesPath, false, true, false, false, true); | |||
| JHtml::_('script', $helperPath, false, true, false, false, true); | |||
| JHtml::_('script', 'system/fields/calendar.min.js', false, true, false, false, true); | |||
| JHtml::_('script', 'system/fields/calendar.js', false, true, false, false, true); | |||
There was a problem hiding this comment.
please revert this change and update the calendar.min.js file with your changes
|
Also needs updating to deconflict with the now merged #17777 |
|
similar #17809 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17793. |
ghost
mentioned this pull request
|
This pr is broken and we have #17809 for the same issue. This should be closed, imho. |
|
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17793 |
|
closed as stated above. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17793. |
Pull Request for Issue # 17744
Summary of Changes
Previously, when we edit an article under publishing tab, the clear button in calendar field did not work if it was a required field.
Now, it clears the calendar field when pressed instead of redirecting (as it did originally).
Changes were made in calendar.js and calendar.php
Testing Instructions
Create an admin form with a required date field. i.e. open administrator\components\com_content\models\forms\article.xml and make field "publish_down" required by adding required="true" to field's xml node.
Go to Joomla! administration panel and open an article edit view.
Finish Publishing field should now be a required field.
Add Finish Publishing date, using the date picker of the calendar
Click "Clear" button on the Calendar.