[4.0] proper html fallback everywhere #18777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrammatiko
changed the title
ghost
mentioned this pull request
richard67
reviewed
Nov 22, 2017
| @@ -0,0 +1,269 @@ | |||
| <html> | |||
| <base> | |||
There was a problem hiding this comment.
Shouldn't this be <head> and not <base>?
There was a problem hiding this comment.
Created PR #18796 to correct this.
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Nov 22, 2017
This error came from PR joomla#18777
laoneo
pushed a commit
to Digital-Peak/joomla-cms
that referenced
this pull request
Dec 18, 2017
laoneo
pushed a commit
to Digital-Peak/joomla-cms
that referenced
this pull request
Dec 18, 2017
…tml (joomla#18796) This error came from PR joomla#18777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #18764 .
Summary of Changes
All index.php fallback to the same error page in case of unsupported PHP version. This should cover the cases @brianteeman mentioned in the issue:
Testing Instructions
You need to edit each of the index.php files (root, installation, administrator) and change the line
to
and then navigate to
//installation//administrator/or any other URI pointing in your server. All cases should respond with the nice html page.
Expected result
Actual result
Documentation Changes Required
Same as before, the js file for the translation is created through the gruntfile and the installation folder, so maintainers need to run the
grunt installationto refresh that file if there are some changes in the languages files.