-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link CSS style strings #19143
Link CSS style strings #19143
Conversation
The Link CSS Style field label should be Link Class. The field adds a class to the menu item link, the current label implies it is adding inline CSS. Updated the label and description as per @ciar4n request
I have tested this item ✅ successfully on c00a60a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19143. |
1 similar comment
I have tested this item ✅ successfully on c00a60a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19143. |
Ready to Commit after two successful tests. |
@@ -80,8 +80,8 @@ COM_MENUS_ITEM_DETAILS="Details" | |||
COM_MENUS_ITEM_FIELD_ALIAS_DESC="The alias is used in the URL when SEF is on." | |||
COM_MENUS_ITEM_FIELD_ALIAS_MENU_DESC="Menu Item to link to." | |||
COM_MENUS_ITEM_FIELD_ALIAS_MENU_LABEL="Menu Item" | |||
COM_MENUS_ITEM_FIELD_ANCHOR_CSS_DESC="An optional, custom style to apply to the menu hyperlink." | |||
COM_MENUS_ITEM_FIELD_ANCHOR_CSS_LABEL="Link CSS Style" | |||
COM_MENUS_ITEM_FIELD_ANCHOR_CSS_DESC="An optional class to apply to the menu hyperlink." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COM_MENUS_ITEM_FIELD_ANCHOR_CSS_DESC="An optional CSS class to apply to the menu hyperlink."
I think it will be more understandable 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As pointed out by @ciar4n in the original issue it could be JavaScript.
Thanks |
The Link CSS Style field label should be Link Class. The field adds a class to the menu item link, the current label implies it is adding inline CSS. Updated the label and description as per @ciar4n request
The Link CSS Style field label should be Link Class. The field adds a class to the menu item link, the current label implies it is adding inline CSS.
Updated the label and description as per @ciar4n request
Pull Request for Issue #19122