-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Switcher is now a Custom Element #19232
Conversation
I have tested this item ✅ successfully on e455b9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232. |
I have tested this item ✅ successfully on e455b9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232. |
Ready to Commit after two successful tests. |
Why is there always a "throbber" outline on the No value? |
Ignore that comment - it was a cache issue |
Nope it was a brian issue and is a problem - you can probably only see it when you tab from one switcher to another |
(i will post a video soon - there are a few issues) |
Brian, I purposely added the pulsating focus state, not an issue. Inspired by Google |
ok - i get it now. its not on the no value but its on the switch |
I have tested this item ✅ successfully on e455b9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232. |
@C-Lodder the src needs to move to the right path |
@dgt41 yeah dont worry I haven't forgotten. |
Hold on tight 😂 |
Summary of Changes
This PR migrates the Switcher field over to a dedicated custom element which has been approved by the a11y team.
Testing Instructions
Go to the Global Configuration (or any other page that uses a switcher) and ensure it works the same as it did before.
Note, please ignore the colours. We still need to publish an update to NPM and properly pull the elements using the new package manager. Once done and we start working on the new template, we'll work the the necessary SCSS changes.
Hope @brianteeman likes the removal or the border radius :)