Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Switcher is now a Custom Element #19232

Merged
merged 4 commits into from
Jan 3, 2018
Merged

[4.0] Switcher is now a Custom Element #19232

merged 4 commits into from
Jan 3, 2018

Conversation

C-Lodder
Copy link
Member

@C-Lodder C-Lodder commented Dec 30, 2017

Summary of Changes

This PR migrates the Switcher field over to a dedicated custom element which has been approved by the a11y team.

Testing Instructions

Go to the Global Configuration (or any other page that uses a switcher) and ensure it works the same as it did before.

Note, please ignore the colours. We still need to publish an update to NPM and properly pull the elements using the new package manager. Once done and we start working on the new template, we'll work the the necessary SCSS changes.

Hope @brianteeman likes the removal or the border radius :)

@ghost
Copy link

ghost commented Dec 30, 2017

I have tested this item ✅ successfully on e455b9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232.

@dgrammatiko
Copy link
Contributor

@C-Lodder nice one! Please check either #19231 or #19184 for the source code folder. Basically you need to move the src to build/webcomponents/field-switcher and then run grunt createElements

@anuragteapot
Copy link
Contributor

I have tested this item ✅ successfully on e455b9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232.

@ghost
Copy link

ghost commented Dec 31, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 31, 2017
@brianteeman
Copy link
Contributor

Why is there always a "throbber" outline on the No value?

@brianteeman
Copy link
Contributor

Ignore that comment - it was a cache issue

@brianteeman
Copy link
Contributor

Nope it was a brian issue and is a problem - you can probably only see it when you tab from one switcher to another

@brianteeman
Copy link
Contributor

(i will post a video soon - there are a few issues)

@C-Lodder
Copy link
Member Author

C-Lodder commented Dec 31, 2017

Brian, I purposely added the pulsating focus state, not an issue. Inspired by Google

@brianteeman
Copy link
Contributor

But why is it always on the NO value

throbber-and-outline

@brianteeman
Copy link
Contributor

ok - i get it now. its not on the no value but its on the switch

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on e455b9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232.

@wilsonge wilsonge merged commit 316c1fe into joomla:4.0-dev Jan 3, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 3, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 3, 2018
@C-Lodder C-Lodder deleted the switcher-ce branch January 3, 2018 00:19
@dgrammatiko
Copy link
Contributor

dgrammatiko commented Jan 3, 2018

@C-Lodder the src needs to move to the right path build\...
and the compiled ones using build.js have to move to media\system\webcomponents\...

@C-Lodder
Copy link
Member Author

C-Lodder commented Jan 3, 2018

@dgt41 yeah dont worry I haven't forgotten. compileElements grunt task didn't work so I'm waiting on your PR

@dgrammatiko
Copy link
Contributor

Hold on tight 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants