-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors exposed by strict and also improve js #20221
Fix errors exposed by strict and also improve js #20221
Conversation
If you want to test subforms, there's one here: |
This 'drone' failure seems to have nothing at all to do with these changes. |
Can you confirm that this addresses the same things as #19722? |
@Quy This PR addresses the Isis template only, #19722 addresses beez3 and protostar as well. Since this one is on top of #12544, it also includes the "strict" fixes which really should have been merged by now. Other than that, it's really an issue of which adds more overhead and complexity to the code and which one reduces it. I'll recuse myself from sharing any opinion on that matter. |
As the author of #19722 I am happy to close my PR, and for this PR and #20224 / #20225 to replace them - though I hope @okonomiyaki3000 will consider and include my recent comments in #19722. |
Just few comments here:
|
Is is also possible to include/fix "modal" type as reported in #11805? |
@Quy It's not appropriate to include it in this PR but yes, I can fix that. |
LOL, wait.... This is going to take more than most of these. I better jump in over there but please don't think of it as related to this PR and don't expect the fix very soon. |
What are we gonna do about this drone failure? Is this for real? I don't buy it. |
Just make it run again. I bet it works this time. |
OK to close #12544 ? |
Drone restarted |
I don't know why this would fail. This PR has nothing to do with jquery.ui.sortable or whatever. |
I have tested this item ✅ successfully on 5e66f87 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20221. |
@okonomiyaki3000 I only noticed this PR after merging #12544 and I think because of that merge we have a conflict now. Could you update this PR please? |
5e66f87
to
1a09ee9
Compare
Rebased with latest staging. Should be correct. |
Don't believe appveyor, it just timed out. |
I have tested this item ✅ successfully on 1a09ee9 For testing I added this to excludes.xml:
|
@viocassel can you please retest? |
I have tested this item ✅ successfully on 1a09ee9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20221. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20221. |
Pull Request for Issue # .
Summary of Changes
This is just #12544 plus some additional improvements.
While that older PR was aimed only at fixing the "strict" errors, this one fixes other problems.
In particular, button groups (radio buttons) will now work properly when used inside of subforms.
Same for Chosen selectors that use coloring based on state.
Also, delegation is used to handle various events. This has several benefits.
This is only a rewrite of the first part of this file. There is likely much more that can be improved.
Testing Instructions
This file only affects the administrator when using the Isis template so use that.
First of all, nothing should be broken. This mainly affects Chosen, radio button groups, and tooltips. So check any pages that have those things.
The main improvements apply to subforms. Subforms with radio buttons set up as
btn-group
should be tested. There are probably none of these in Joomla because they didn't really work before this patch. So make one and test it. Same goes for Chosens used in subforms with thechzn-color-state
class.Expected result
When you dynamically add a subform row that contains radio buttons, Chosen, or tooltips, these things should be initialized properly in the new row. Before this patch they were not.
Actual result
Oh, it works.
Documentation Changes Required
Probably not. Unless there were previously some documented warnings about using radio buttons or Chosens in subforms. If so, those warnings may be deleted as they will no longer apply.