Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make media field initialize itself when a new subform row is added #20230

Merged
merged 2 commits into from
May 10, 2019

Conversation

okonomiyaki3000
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Subform repeatable has a function fixScripts which calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.

Note: this PR doesn't really fix anything. the media field type already works with repeatable subforms. This just does it in a somewhat better way.

Testing Instructions

Set up a subform containing a media field. There's a subform in the redirect plugin that's simple to use for this purpose.

Open up the form and create new rows. The media field in each new row should function properly.

Expected result

Media field functions normally.

Actual result

Media field functions normally.

Documentation Changes Required

None

@Quy
Copy link
Contributor

Quy commented Apr 26, 2018

I have tested this item ✅ successfully on 83f9b21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 83f9b21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.

@Quy
Copy link
Contributor

Quy commented Feb 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-staging labels Feb 3, 2019
@ghost ghost added the J3 Issue label Apr 5, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@alikon
Copy link
Contributor

alikon commented May 2, 2019

@HLeithner please a final response

1 year old rtc pr

@okonomiyaki3000
Copy link
Contributor Author

OK, I'll get right on it

@HLeithner HLeithner merged commit 2fc9049 into joomla:staging May 10, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 10, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 10, 2019
@okonomiyaki3000 okonomiyaki3000 deleted the fix-subform-media branch May 13, 2019 00:25
@okonomiyaki3000
Copy link
Contributor Author

See also #20231

tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants