[4.0] Convert bootstrap.tab to uitab #21805
Conversation
administrator/components/com_contact/tmpl/contact/edit_params.php
Outdated
Show resolved
Hide resolved
| @@ -42,9 +42,9 @@ | |||
| <?php echo LayoutHelper::render('joomla.edit.title_alias', $this); ?> | |||
|
|
|||
| <div> | |||
| <?php echo HTMLHelper::_('bootstrap.startTabSet', 'myTab', array('active' => 'details')); ?> | |||
| <?php echo HTMLHelper::_('uitab.startTabSet', 'myTab', array('active' => 'details')); ?> | |||
There was a problem hiding this comment.
This needs a $this->useCoreUI = true; (it's required for any view using the joomla.edit.params layout - as any extra tabs will use that flag for extra tabs plugins may be adding)
There was a problem hiding this comment.
Can you check in your browser please because I tested each one and just retested this one and it doesnt have a problem without it
There was a problem hiding this comment.
Re-read this comment. Are you saying it is needed because a plugin might require it. If so then it's not just this file that it needs to be added in.
There was a problem hiding this comment.
So in the joomla.edit.params it will loop through and render all fieldsets that are not in the ignored fieldsets list. Remember what we were doing with the custom fields in the user groups view here https://github.com/joomla/joomla-cms/pull/21696/files
In order to render as a tab it needs to know whether to use bootstrap or the custom elements set. That's what the useCoreUI param is doing https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/edit/params.php#L112
|
Before looks better. |
|
@TobsBobs this PR is better to read which Tab is active. |
|
@brianteeman you are aware it doesn't touch "Options" (from "Global Configuration" to "Users")? |
|
This PR is not about design - that can always be changed - it is about the underlying code |
|
@brianteeman thanks for Info. |
|
@franz-wohlkoenig the options "tabs" are not created with bootstrap.tab |
|
i have only looked at Design as i thought thas the Difference between "Bootstrap" and "UI" but know now its about underlying Code. |
|
Nice stuff! Thanks! |
|
thanks |
This converts the majority of the instances in the administrator of the boostrap tabset to the ui tabset. It doesnt touch the frontend and it doesnt touch com-contact which I couldnt get to work after the conversions
Before (example)
After (example)