Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Privacy XML export] standardized convention for domain (Redo #22240) #22253

Merged
merged 8 commits into from
Sep 22, 2018

Conversation

cyrezdev
Copy link
Contributor

REDO #22240

Use standardized strings for domain name and description in Privacy request xml export file.

@cyrezdev cyrezdev changed the title [Privacy XML export] standardized convention for domain (Redo https://github.com/joomla/joomla-cms/pull/22240) [Privacy XML export] standardized convention for domain (Redo #22240) Sep 19, 2018
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 18faa4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22253.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Sep 20, 2018

I have tested this item ✅ successfully on 18faa4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22253.

@Quy
Copy link
Contributor

Quy commented Sep 20, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22253.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 20, 2018
@mbabker mbabker added this to the Joomla 3.9.0 milestone Sep 22, 2018
@mbabker mbabker merged commit 3a2c1ab into joomla:staging Sep 22, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 22, 2018
@mbabker
Copy link
Contributor

mbabker commented Sep 22, 2018

https://docs.joomla.org/J3.x:Integrate_Extensions_with_the_Privacy_Component needs to be updated to reflect the standardization of name/description

@cyrezdev
Copy link
Contributor Author

cyrezdev commented Sep 26, 2018

Well, someone edited code example before i do ;-)

About details for name and description, maybe to give some insights and recommendation on naming to keep futur usability when xml use programmatically ?

eg by replacing this part:

Domain name - A name to identify the domain
Domain description - A short description of the data contained in the domain

By this:

Domain name - A name to identify the domain (lowercase underscore separated string for reusability as a variable) eg "user_galleries"
Domain description - A short description of the data contained in the domain (lowercase underscore separated string recommended for reusability as a variable) eg "joomla_user_galleries_data"

RTC and if ok, i will update docs.
Note that if for name, it seems to me a good idea to use a variable, maybe not mandatory to request the same for description (recommended, but not required ?).

So, open to comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants