Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_actionlogs][3.9]Apply timezone to datetime in com_actionlogs emails #22744

Merged
merged 2 commits into from
Oct 24, 2018
Merged

[com_actionlogs][3.9]Apply timezone to datetime in com_actionlogs emails #22744

merged 2 commits into from
Oct 24, 2018

Conversation

PhilETaylor
Copy link
Contributor

Steps to reproduce the issue

Closes #22711

Enable the sending of Action Log entries to a Super Admin by Mail in Joomla 3.9
Set your Joomla Global Timezone to be something the other side of the world
Generate a load of emails

Expected result

Any reference to the date/time an event occured should be translated to the Joomla Global Configuration Timezone/offset

Actual result

The date/time right now is UTC/GMT, but a Joomla Super Admin the other side of the world (with a server another third of the way around the world) is confused and assumes its local time, so would be best when giving the date/time to tell the recipient WHAT timezone that timestamp relates to.

screenshot 2018-10-19 at 00 54 31

@PhilETaylor PhilETaylor changed the title Apply timezone to datetime in com_actionlogs emails [com_actionlogs][3.9]Apply timezone to datetime in com_actionlogs emails Oct 20, 2018
@laoneo
Copy link
Member

laoneo commented Oct 21, 2018

This is actually sent in the timezone of the current logged in user. If the recipient is in a different timezone then the date is wrong.

@mbabker
Copy link
Contributor

mbabker commented Oct 24, 2018

This is actually sent in the timezone of the current logged in user. If the recipient is in a different timezone then the date is wrong.

Changed this to:

  • Hardcode the time format (so the email doesn't have a different format based on the active user)
  • Hardcode the date/time string to UTC

Good to go here, please test

@mbabker mbabker added this to the Joomla 3.9.0 milestone Oct 24, 2018
@mbabker mbabker merged commit 71a2a49 into joomla:staging Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants