Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32342] Fix wrong pluralization #2275

Closed
wants to merge 1 commit into from
Closed

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Oct 17, 2013

The pluralization of the visitors counter in the backend mod status is wrong.

Before

@BUG mod_status before

Note the plural form for 1 Visitors and 1 Admins.

After

mod_status7


The original proposal was:
mod_status fixed
the text had been moved to a tooltip.

@brianteeman
Copy link
Contributor

I agree that the plural is wrong but moving the description to a tooltip makes the 2 icons identical and meaningless

@elkuku
Copy link
Contributor Author

elkuku commented Oct 17, 2013

How about this approach:
mod_status2

Note that the underlying issue is passing a HTML string to JText::plural() instead of an integer.....

So to make it work using the bootstrap badges, you would have to include the HTML markup in the language files.

@brianteeman
Copy link
Contributor

Sorry still doesn't look right to me. Personal opinion of course

@elkuku
Copy link
Contributor Author

elkuku commented Oct 17, 2013

While I somewhat agree.... any suggestion ? 😉

@betweenbrain
Copy link
Contributor

Is it not possible to fix the pluralization using the original (https://f.cloud.github.com/assets/33978/1353270/ca86b2fc-3742-11e3-9a1d-39379776751c.png) layout?

@elkuku
Copy link
Contributor Author

elkuku commented Oct 18, 2013

OK, so now it looks like this
mod_status7

There is however a slight B/C issue, requiring an adjustment of language files:
mod_status6

Also, I'm not sure about RTL languages.

There is definitely no easy fix for this, preserving the current layout.

@elkuku
Copy link
Contributor Author

elkuku commented Oct 19, 2013

For reference (or debugging), the current arabic version looks like this:
mod_status9

This has already applied the CSS patch from @infograf768

أي شكاوى؟

@elkuku elkuku deleted the mod_status branch October 20, 2013 14:57
@elkuku
Copy link
Contributor Author

elkuku commented Oct 21, 2013

Another idea we are trying in JTracker:
jtracker-debug-toolbar
The orange "2" means, that there are 2 untranslated language strings 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants