Re-add generic CSS classes in subforms. #23190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on d1d990f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23190. |
wilsonge
approved these changes
Nov 28, 2018
|
I have tested this item ✅ successfully on d1d990f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23190. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23190. |
joomla-cms-bot
added
PR-staging
and removed
RTC
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When support for nested subforms was added in #17552 (Joomla 3.9.0) the generic CSS classes group-add, group-remove and group-move were replaced by subform-specific classes which include the subform id. Unfortunately, the absence of the generic classes makes it harder to style these elements, so this PR adds the generic classes back in.
Testing Instructions
Set up a subform so you check the markup. A good example can be found in #17552
In your browser, view source or use dev tools to check that the generic group-add, group-remove and group-move classes are now included as well as the group-add-xx, group-remove-xx and group-move-xx classes (where xx is a subform id).
Expected result
Generic and subform-specific classes should both be available.
Actual result
Only subform-specific classes are available.
Documentation Changes Required
None.