Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9][a11y] Improve accessiblity in mod_finder #23693

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Jan 27, 2019

Pull Request for Issue # .

Summary of Changes

Added role="search" attribute to the form tag

Testing Instructions

  • code inspection
  • use screen reader (e.g. NVDA) and see that the search form is accessible during navigation as a landmark

Expected result

Attribute role="search" defines one of the landmarks of the page. This allows the user of assistive technology to easily navigate to the finder module.

Actual result

Assistive technology does not recognize the form as a landmark.

Documentation Changes Required

no

@chmst
Copy link
Contributor

chmst commented Jan 27, 2019

I have tested this item ✅ successfully on da0c2d2

Tested with code inspection


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23693.

@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on da0c2d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23693.

@Quy
Copy link
Contributor

Quy commented Jan 27, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23693.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 27, 2019
@HLeithner HLeithner merged commit df8a8ca into joomla:staging Feb 1, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Feb 1, 2019
@HLeithner HLeithner added this to the Joomla 3.9.3 milestone Feb 1, 2019
@wojsmol wojsmol deleted the j3-mod_finder_a11n branch February 1, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants