Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][a11y] Missing ID attribute in the input field on the Smart Search module #23870

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Feb 10, 2019

Pull Request for Issue #23861.

Summary of Changes

Added missing id to label in mod_finder

Testing Instructions

code review

Expected result

The input field should have an ID attribute so that browsers and assistive technologies recognize the label for this field.

Actual result

There is a "Search" label for the input field in the Smart Search module. The label can only be visible for screen readers. Unfortunately, the attribute for the label refers to an ID that does not exist because the input field does not have an ID attribute.

Documentation Changes Required

no

@wojsmol wojsmol changed the title [4.0][a11y]Missing ID attribute in the input field on the Smart Search module [4.0][a11y] Missing ID attribute in the input field on the Smart Search module Feb 10, 2019
@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on b30f56c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Feb 11, 2019

I have tested this item ✅ successfully on b30f56c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.

@Quy
Copy link
Contributor

Quy commented Feb 11, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 11, 2019
@wilsonge wilsonge merged commit 19e55c7 into joomla:4.0-dev Feb 27, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 27, 2019
@wojsmol wojsmol deleted the 40-a11y-mod_finder-id branch February 27, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants