Fix category batch copy #2632
Merged
Fix category batch copy #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infograf768
added a commit
that referenced
this pull request
Dec 4, 2013
Fix category batch copy. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Try batch copy a category if
This will fail with a fatal error in case of batchAccess or a lengthy error message in case of batchLanguage. The categories will be copied (sometimes even multiple times), but the access levels and languages are not correctly changed.
Bugtracking
The problem is that the table->reset() function didn't reset the
_locationand_location_idproperties of the table. Thus subsequent stores tried to move the categories again, which failed due to wrong parent ids.Fix
This PR adds JTableNested->reset() which will reset the locations (
using $this->setLocation(0)) after the parent reset function was executed.Fixes #2628
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32827