Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Bump PHP minimum to 7.2.5 #27191

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Dec 1, 2019

Pull Request for Motion: PROD2019/012

Summary of Changes

As of https://volunteers.joomla.org/departments/production/reports/1128-production-dept-meeting-november-05-2019 (PROD2019/012) the minimum PHP for Joomla 4.0 is 7.2.5

Minimum PHP Version for Joomla 4.0 set to PHP 7.2.5 (PROD2019/012)
Proposed by George Wilson
The motion passed with unanimous consent.

Testing Instructions

Try to install on a php version lower than 7.2.5

Expected result

error message

Actual result

minimum is 7.2.0

Documentation Changes Required

This needs to be updated in the docs. cc @wilsonge

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9cf4f5e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27191.

@mbabker
Copy link
Contributor

mbabker commented Dec 1, 2019

Please don’t link external things as an issue, even if it is a Joomla owned resource. More than once a pull request has been based on something external (like a Twitter thread or a closed access Facebook group) and the external source is removed, which also removes any context of the issue report.

An issue tracker should be a canonical source of information about a project’s issues and changes. Relying on external sources is a great way to break that information history.

@alikon
Copy link
Contributor

alikon commented Dec 2, 2019

I have tested this item ✅ successfully on 9cf4f5e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27191.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Dec 2, 2019
@alikon
Copy link
Contributor

alikon commented Dec 2, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27191.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 2, 2019
@zero-24
Copy link
Contributor Author

zero-24 commented Dec 2, 2019

@mbabker something like i did above now? Or do you have something else in mind?

@HLeithner HLeithner merged commit 462b587 into joomla:4.0-dev Dec 2, 2019
@HLeithner
Copy link
Member

Thanks Tobias

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 2, 2019
@HLeithner HLeithner added this to the Joomla 4.0 milestone Dec 2, 2019
@mbabker
Copy link
Contributor

mbabker commented Dec 2, 2019

@zero-24 yeah, that works. Having the link is fine if you want to refer to a source for more info, but it's a good idea to make sure the most pertinent bits are inlined into the issue just so things don't get lost.

@Quy Quy added the PR-4.0-dev label Dec 2, 2019
@zero-24 zero-24 deleted the php725-4.0-dev branch December 2, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants