Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] TinyMCE mobile #27501

Merged
merged 3 commits into from
Jan 23, 2020
Merged

[4.0] TinyMCE mobile #27501

merged 3 commits into from
Jan 23, 2020

Conversation

brianteeman
Copy link
Contributor

This option has not done anything for a long time so it should be removed.

Yoiu can confirm this bt testing the editor AFTER applying the PR and you will see that you get the correct tinymce mobile experience

As shown in the screenshots below

(I will deal with the toggle button in another PR)

image
image

This option has not done anything for a long time so it should be removed.

Yoiu can confirm this bt testing the editor AFTER applying the PR and you will see that you get the correct tinymce mobile experience

As shown in the screenshots below

(I will deal with the toggle button in another PR)
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 12, 2020
@toivo
Copy link
Contributor

toivo commented Jan 16, 2020

I have tested this item 🔴 unsuccessfully on 1aefa3a

Tested in Nightly build of 16 January and Android, no change in mobile behaviour.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501.

@Fedik
Copy link
Member

Fedik commented Jan 20, 2020

I have tested this item ✅ successfully on 1aefa3a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 1aefa3a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501.

@Quy
Copy link
Contributor

Quy commented Jan 22, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2020
@HLeithner
Copy link
Member

please solve the conflict

@brianteeman
Copy link
Contributor Author

resolved

@HLeithner HLeithner merged commit 1c9f6d8 into joomla:4.0-dev Jan 23, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 23, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 23, 2020
@brianteeman
Copy link
Contributor Author

thanks a lot

@brianteeman brianteeman deleted the saturday5 branch January 23, 2020 12:52
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
This option has not done anything for a long time so it should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants