Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] com_menu - Change Featured Icon to Home Icon in #29016

Merged
merged 5 commits into from
May 13, 2020
Merged

[4.0] com_menu - Change Featured Icon to Home Icon in #29016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c9c3bf
Change Featured Icon to Home Icon in com_menu
coolcat-creations May 9, 2020
0b04774
Change Icon class
coolcat-creations May 9, 2020
109a7b2
Change Default icon in sidebar menu too
coolcat-creations May 9, 2020
38bc020
Different class for disabled Home item
coolcat-creations May 10, 2020
0838c6d
Update administrator/components/com_menus/tmpl/items/default.php
coolcat-creations May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change Default icon in sidebar menu too
  • Loading branch information
@coolcat-creations
coolcat-creations committed May 9, 2020
commit 109a7b20433d7d1820777540d36def151723d8fd
2 changes: 1 addition & 1 deletion administrator/modules/mod_menu/tmpl/default_submenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
{
if (substr($iconImage, 0, 6) == 'class:' && substr($iconImage, 6) == 'icon-home')
{
$iconImage = '<span class="home-image fas fa-star" aria-hidden="true"></span>';
$iconImage = '<span class="home-image fas fa-home" aria-hidden="true"></span>';
$iconImage .= '<span class="sr-only">' . Text::_('JDEFAULT') . '</span>';
}
elseif (substr($iconImage, 0, 6) == 'image:')
Expand Down
2 changes: 1 addition & 1 deletion administrator/modules/mod_submenu/src/Menu/Menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public static function preprocess($parent)
{
if (substr($iconImage, 0, 6) === 'class:' && substr($iconImage, 6) === 'icon-home')
{
$iconImage = '<span class="home-image fas fa-star" aria-hidden="true"></span>';
$iconImage = '<span class="home-image fas fa-home" aria-hidden="true"></span>';
$iconImage .= '<span class="sr-only">' . Text::_('JDEFAULT') . '</span>';
}
elseif (substr($iconImage, 0, 6) === 'image:')
Expand Down