Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] correct single line comment style #31946

Merged
merged 2 commits into from
Jan 12, 2021
Merged

[4] correct single line comment style #31946

merged 2 commits into from
Jan 12, 2021

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Jan 9, 2021

Summary of Changes

change /** */ syntax to // to comply with https://developer.joomla.org/coding-standards/inline-code-comments.html for single line comments

No code changes.

@Quy
Copy link
Contributor

Quy commented Jan 9, 2021

I have tested this item ✅ successfully on 28e1a8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31946.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 28e1a8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31946.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31946.

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev RTC This Pull Request is Ready To Commit labels Jan 9, 2021
@Quy Quy added this to the Joomla 4.0 milestone Jan 10, 2021
@wilsonge
Copy link
Contributor

This is the same line that's in index.php for each app entry point. If you're doing it here we should be consistent in doing it everywhere

Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
@PhilETaylor

This comment was marked as abuse.

@drmenzelit drmenzelit merged commit ae1a795 into joomla:4.0-dev Jan 12, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2021
@drmenzelit
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants