-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename incorrectly cased files on updates or when fixing database #32006
Rename incorrectly cased files on updates or when fixing database #32006
Conversation
…-fix-file-casing-mod-2
@bembelimen @chmst @softforge @wilsonge Please test. |
I have tested this item ✅ successfully on 4d0ca0f Windows 10, PHP 8.0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32006. |
This comment was marked as abuse.
This comment was marked as abuse.
Sure, but that's outside the scope of this PR. |
Using the "Fix database" button for this is fundamentally wrong. Joomla 4 has already changed its name to Database: update structure to try to make it clearer that it only touches database structure changes and not any content changes. Adding a fix files functionality to this button is a step backwards not forwards. |
And that was wrong because currently it still does other stuff, too.
Yes, but it wasn't in the scope of the original PR #30802 either to fix that all. |
I have tested this item ✅ successfully on 4d0ca0f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32006. |
Would be nice to get a test on Linux, too. |
Tested on Linux works as expected. |
RTC? |
@Gostn Please stop to tell us maintainers and JBS members what we shall do. We know it by ourselves. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32006. |
Please stop your personal attacks. I was asking (!) for RTC cause sometimes it is forgotton. |
@Gostn If you see a personal attack (I don't see some) feel free to contact conflict resolution team and report a CoC violation. |
Please stop to tell us volunteers what we shall do. We know it by ourselves. |
Pull Request for Issues #23725 and #30736 .
Replaces Pull Request #30802 .
Summary of Changes
This pull request (PR) attempts to implement case sensitive file rename and rename some incorrectly cased files.
It is based on PR #30802 plus my corrections for OSX.
Thanks to @SharkyKZ for the original PR #30802.
Testing Instructions
Testers please report back which server operating system (Linux, Windows, OSX) you have used for your test. If you have several available, test with all of them.
Install Joomla! <= 3.9.23 => check the following files:
joomla-cms/administrator/components/com_admin/script.php
Lines 2670 to 2674 in f3666c8
Use the update package built by drone for this PR for Update
Now check the file list again => files should in all three test cases have the correct name.
Actual result BEFORE applying this Pull Request
Incorrectly cased files present.
Expected result AFTER applying this Pull Request
No incorrectly files after update or database fix or new installation.
Documentation Changes Required
None.