Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Mail template: html to plain fallback and vice versa #32118

Merged
merged 4 commits into from
Feb 20, 2021

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jan 23, 2021

Pull Request for Issue #31919 .

Summary of Changes

Mail template, html to plain fallback and vice versa.
Also I have added "scroll up" for "test email" button.

Testing Instructions

Please follow #31919

Additionally, after send "test email" the page should be scrolled up, no need to do it manually.
So not forget to run npm install.

Actual result BEFORE applying this Pull Request

The error "empty body"

Expected result AFTER applying this Pull Request

No error, email sent.

Documentation Changes Required

nope

@Fedik
Copy link
Member Author

Fedik commented Jan 23, 2021

Please someone add RB tag, as it was in the original issue.

@ceford
Copy link
Contributor

ceford commented Feb 11, 2021

I have tested this item ✅ successfully on 2e3bf2f

The email was sent to xxx@yyy.zzz using SMTP. You should check that you've received the test email.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32118.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 2e3bf2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32118.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32118.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2021
@wilsonge wilsonge merged commit 5b9b1d3 into joomla:4.0-dev Feb 20, 2021
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 20, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 20, 2021
@Fedik Fedik deleted the mailtemplate-fallback branch February 21, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants