-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Mail template: html to plain fallback and vice versa #32118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.0-dev
labels
Jan 23, 2021
Please someone add RB tag, as it was in the original issue. |
PhilETaylor
reviewed
Jan 23, 2021
I have tested this item ✅ successfully on 2e3bf2f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32118. |
I have tested this item ✅ successfully on 2e3bf2f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32118. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32118. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #31919 .
Summary of Changes
Mail template, html to plain fallback and vice versa.
Also I have added "scroll up" for "test email" button.
Testing Instructions
Please follow #31919
Additionally, after send "test email" the page should be scrolled up, no need to do it manually.
So not forget to run
npm install
.Actual result BEFORE applying this Pull Request
The error "empty body"
Expected result AFTER applying this Pull Request
No error, email sent.
Documentation Changes Required
nope