Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix Frontend Editing Article Error #32524

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR fixes issue with editing an existing article from frontend using an Author account (basically, an account with Edit State Permission enabled for the article being edited but without Edit State Permission in component level)

Testing Instructions

  1. Login to administrator area of your site using a super admin account, edit an article, look at Permission tab, Select Author user group, set Edit and Edit State Permission for that article to Allowed.
  2. Login to frontend of of your site using an Author account, edit the above article
  3. Before patch: You get 0 Invalid field: Start Featured error
  4. After patch, the article is being saved properly.

@toivo
Copy link
Contributor

toivo commented Feb 26, 2021

I have tested this item ✅ successfully on f4fa351

Tested successfully in Beta8-dev full version of 26 February in Wampserver using PHP 8.0.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32524.

@ChristineWk
Copy link

I have tested this item ✅ successfully on f4fa351


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32524.

@Quy
Copy link
Contributor

Quy commented Feb 26, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32524.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2021
@infograf768 infograf768 merged commit 9ca4e56 into joomla:4.0-dev Feb 26, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2021
@infograf768
Copy link
Member

infograf768 commented Feb 26, 2021

This one works perfectly whether workflow is implemented or not.
Tks.

@infograf768 infograf768 added this to the Joomla 4.0 milestone Feb 26, 2021
@joomdonation joomdonation deleted the fix_edit_article_author branch February 27, 2021 01:38
@pjdevries
Copy link
Contributor

Unfortunately this PR does not seem to fix creating new articles in the front end. See #36500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants