Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Remove use of deprecated triggerEvent call #33166

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[4] Remove use of deprecated triggerEvent call #33166

merged 2 commits into from
Apr 23, 2021

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Apr 16, 2021

Pull Request for Issue # .

Summary of Changes

Remove use of deprecated triggerEvent call in favour of a Joomla 4 way of dispatching events

Testing Instructions

Load Home Dashboard in Joomla 4 freshly installed. Note the sample plugins are all listed in the Sample data plugin

Actual result BEFORE applying this Pull Request

Load Home Dashboard in Joomla 4 freshly installed. Note the sample plugins are all listed in the Sample data plugin

Expected result AFTER applying this Pull Request

Load Home Dashboard in Joomla 4 freshly installed. Note the sample plugins are all listed in the Sample data plugin

Documentation Changes Required

None. Code review only.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 098c835


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

@brianteeman
Copy link
Contributor

When you have no sampledata plugins enabled then you get this error

Warning: array_filter() expects parameter 1 to be array, null given in C:\htdocs\joomla-cms\administrator\modules\mod_sampledata\mod_sampledata.php on line 15

@PhilETaylor

This comment was marked as abuse.

Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
@PhilETaylor

This comment was marked as abuse.

@YatharthVyas
Copy link
Contributor

I have tested this item ✅ successfully on 3660973


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 3660973

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

@PhilETaylor

This comment was marked as abuse.

@Quy
Copy link
Contributor

Quy commented Apr 23, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 23, 2021
@chmst chmst added this to the Joomla 4.0 milestone Apr 23, 2021
@chmst chmst merged commit d714e26 into joomla:4.0-dev Apr 23, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2021
@chmst
Copy link
Contributor

chmst commented Apr 23, 2021

Thanks!

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants