[4.0] Categories don't contain only articles #33186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure that the bug is not the text but that it should only be shown when the context is com_content? In J3 it only displays in com_content |
|
Oops, that could be the case. I just assumed it works, but didn't test it. I'll check that and close this PR in the meantime. |
|
@brianteeman You're right, it only affects articles. But the bug is also in J3, as it shows in all category types, not only com_content. It probably shouldn't have been implemented in the com_category code 😄 |
|
New PR: #33190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch copying a category allows to reverse order all articles in the selected categories. But categories are not only for articles. It can be anything. So "items" is a better term.
Summary of Changes
Changing the string to order items, not articles.
Testing Instructions
Go to any categories manager (eg articles categories, banner categories, contact categories), select at least one category and then select "Batch" from the "Actions" dropdown.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None