-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Moving reusable parts of blankstate layout to a JLayout #33288
Conversation
One thing I wondered: The "Learn More" link currently opens in the same tab. Maybe it makes more sense to open it in a new tab? Since I guess usually the people going to read the help page don't actually want to leave the admin backend. |
This comment was marked as abuse.
This comment was marked as abuse.
From an accessibility perspective it is OK to open a new window in this case because the content is designed to be read with the web page. This is even an example use case in the WCAG docs |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
administrator/components/com_banners/tmpl/banners/blankstate.php
Outdated
Show resolved
Hide resolved
I've added |
I think from a first look of it, it should work fine with this PR |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Didn't even notice this, but you're right. It doesn't look nice. Open for suggestions (could also be done in a separate PR). |
This comment was marked as abuse.
This comment was marked as abuse.
administrator/components/com_banners/tmpl/banners/blankstate.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Teeman <brian@teeman.net>
administrator/components/com_contact/tmpl/contacts/blankstate.php
Outdated
Show resolved
Hide resolved
administrator/components/com_messages/tmpl/messages/blankstate.php
Outdated
Show resolved
Hide resolved
administrator/components/com_privacy/tmpl/requests/blankstate.php
Outdated
Show resolved
Hide resolved
administrator/components/com_contact/tmpl/contacts/blankstate.php
Outdated
Show resolved
Hide resolved
administrator/components/com_messages/tmpl/messages/blankstate.php
Outdated
Show resolved
Hide resolved
administrator/components/com_privacy/tmpl/requests/blankstate.php
Outdated
Show resolved
Hide resolved
administrator/components/com_privacy/tmpl/consents/blankstate.php
Outdated
Show resolved
Hide resolved
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on 17298b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33288. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33288. |
Thanks! |
Pull Request for Issue #33279 .
Summary of Changes
Testing Instructions
Check the newly introduced blankstate layouts. They should look the same before and after this PR.
Documentation Changes Required
Should be included in the documentation about blankstate layouts when/if/once that exists