Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix com redirect modal #33588

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented May 6, 2021

Pull Request for Issue #33579

Summary of Changes

Adding modal markup for the System Plugin link

Testing Instructions

Try enabling using the link to the redirect plugin in an empty state (no redirect links listed)

Actual result BEFORE applying this Pull Request

Nothing happens

Expected result AFTER applying this Pull Request

Modal opens

Documentation Changes Required

none

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

Wrong branch chosen for the PR. Should be 4.0-dev but is for staging.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

Maybe I should merge it by review and then move to a place without telephone and internet ;-)

@Bakual Bakual changed the base branch from staging to 4.0-dev May 6, 2021 18:46
@Bakual
Copy link
Contributor Author

Bakual commented May 6, 2021

Pfft :)

@Bakual Bakual changed the title 4 fix com redirect modal [4.0] Fix com redirect modal May 6, 2021
@Quy Quy removed the PR-staging label May 6, 2021
@PhilETaylor

This comment was marked as abuse.

@wilsonge wilsonge merged commit 4556077 into joomla:4.0-dev May 6, 2021
@wilsonge
Copy link
Contributor

wilsonge commented May 6, 2021

Thanks!

@Bakual Bakual deleted the 4_FixComRedirectModal branch May 6, 2021 21:55
@zero-24 zero-24 added this to the Joomla 4.0 milestone May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants