Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Fix Undefined class RuntimeException #34331

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[3] Fix Undefined class RuntimeException #34331

merged 1 commit into from
Jun 21, 2021

Conversation

PhilETaylor
Copy link
Contributor

Code review.

This is a namespaced file, and therefore any reference to RuntimeException needs to be namespaced back to the root.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on a15f0dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34331.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 2, 2021

I have tested this item ✅ successfully on a15f0dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34331.

@Quy
Copy link
Contributor

Quy commented Jun 2, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34331.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 2, 2021
@bembelimen bembelimen merged commit db04e2f into joomla:staging Jun 21, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 21, 2021
@bembelimen
Copy link
Contributor

Thanks

@bembelimen bembelimen added this to the Joomla 4.0 milestone Jun 21, 2021
@laoneo
Copy link
Member

laoneo commented Jun 21, 2021

This is not on milestone 4.

@bembelimen bembelimen removed this from the Joomla 4.0 milestone Jun 21, 2021
@bembelimen
Copy link
Contributor

Right, was too much Joomla! 4 stuff today

@zero-24 zero-24 added this to the Joomla! 3.9.28 milestone Jun 21, 2021
@joomla joomla locked and limited conversation to collaborators Jun 21, 2021
@joomla joomla unlocked this conversation Jun 21, 2021
@zero-24
Copy link
Contributor

zero-24 commented Jun 21, 2021

But it needs the 3.9 milestone ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants