Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added php8 to list of forbidden executable extensions #35000

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

SniperSister
Copy link
Contributor

Summary of Changes

Added PHP8 to the hardcoded list of executables

Testing Instructions

Verify by code review

@SniperSister SniperSister self-assigned this Jul 31, 2021
@richard67 richard67 changed the title [3.10] Added php8 to list of forbidden executable extensions Added php8 to list of forbidden executable extensions Jul 31, 2021
@richard67
Copy link
Member

As it's for staging I've removed the "[3.10]" from the title.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 595e238

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 595e238


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@SniperSister SniperSister added the RTC This Pull Request is Ready To Commit label Jul 31, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@richard67
Copy link
Member

@SniperSister It's not sufficient to set the RTC label on GitHub to get the right status shown in the issue tracker. It needs to use the tracker and change status there. I've done that here now.

@richard67
Copy link
Member

Drone failing for unrelated reasons ... restarted to see if it succeeds this time.

@brianteeman
Copy link
Contributor

I have not tested this item.

reverting my successful test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@richard67
Copy link
Member

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 31, 2021
@RickR2H
Copy link
Member

RickR2H commented Aug 2, 2021

I have tested this item ✅ successfully on 595e238


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@richard67 richard67 added the RTC This Pull Request is Ready To Commit label Aug 2, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 595e238

The reasoning behind this list makes it incomplete


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@richard67
Copy link
Member

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 2, 2021
@zero-24
Copy link
Contributor

zero-24 commented Aug 8, 2021

Merging to sync up with 4.0: #35001 Thanks!

@zero-24 zero-24 merged commit 9523fb6 into joomla:staging Aug 8, 2021
@zero-24 zero-24 added this to the Joomla 3.10.0 milestone Aug 8, 2021
@SniperSister SniperSister deleted the 3x-php8filter branch March 3, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants