-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Subform styling for non table layout #35142
Conversation
this for 4.0.x |
Hello Fedik, Nonetheless good addition :) |
I have tested this item ✅ successfully on 34a1de2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142. |
I have added a light background for "draggable" section, |
Can you use the same styling for the dragging as is used when you are ordering a menu item etc. That will make the ui more consistent |
yes, if someone tell me where I can copy that ;) |
It's coming from dragula in media/vendor |
ah, wait, that toxic green? no, not allowed :) |
I have tested this item ✅ successfully on ff878dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142. |
I have tested this item ✅ successfully on ff878dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142. |
Thanks! |
Summary of Changes
Fixing subform styling.
Adopted from joomla 3
Testing Instructions
Apply patch, run
node build/build.js --compile-css
Add subform field somewhere, example in mod_custom xml
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required