Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Subform styling for non table layout #35142

Merged
merged 7 commits into from
Aug 25, 2021
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 15, 2021

Summary of Changes

Fixing subform styling.
Adopted from joomla 3

Testing Instructions

Apply patch, run node build/build.js --compile-css

Add subform field somewhere, example in mod_custom xml

<field type="subform" name="subform" label="subform" multiple="true">
  <form>
    <field type="text" name="text" label="text" />
    <field type="textarea" name="textarea" label="textarea" />
  </form>
</field>

Actual result BEFORE applying this Pull Request

Screenshot_2021-08-15_14-18-40

Expected result AFTER applying this Pull Request

Screenshot_2021-08-15_14-41-32

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 15, 2021
@Fedik
Copy link
Member Author

Fedik commented Aug 15, 2021

this for 4.0.x

@Fedik Fedik changed the title [4.0] Subform styling for non table layout [4] Subform styling for non table layout Aug 15, 2021
@Fedik Fedik changed the title [4] Subform styling for non table layout [4.0] Subform styling for non table layout Aug 15, 2021
@Waleet
Copy link

Waleet commented Aug 16, 2021

Hello Fedik,
I tested your changes successfully on my machine.
Although I noticed that dragging and dropping feels a bit clunky.
You have to be very precise with the mouse to grab an item.
Maybe that is tweakable?
Also while holding on to an item it becomes hard to see what you´re currently holding.
That may be because white on white is hard to see.

Nonetheless good addition :)

@Waleet
Copy link

Waleet commented Aug 16, 2021

I have tested this item ✅ successfully on 34a1de2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.

@Fedik
Copy link
Member Author

Fedik commented Aug 16, 2021

Also while holding on to an item it becomes hard to see what you´re currently holding.

I have added a light background for "draggable" section,
Please test again.

@brianteeman
Copy link
Contributor

Can you use the same styling for the dragging as is used when you are ordering a menu item etc. That will make the ui more consistent

@Fedik
Copy link
Member Author

Fedik commented Aug 16, 2021

Can you use the same styling for the dragging as is used when you are ordering a menu item etc. That will make the ui more consistent

yes, if someone tell me where I can copy that ;)

@brianteeman
Copy link
Contributor

It's coming from dragula in media/vendor

@Fedik
Copy link
Member Author

Fedik commented Aug 16, 2021

ah, wait, that toxic green? no, not allowed :)

@Fedik
Copy link
Member Author

Fedik commented Aug 16, 2021

okay, changed, however I not like that color.
just for consistency

Screenshot_2021-08-16_17-34-19

@AndySDH
Copy link
Contributor

AndySDH commented Aug 17, 2021

I have tested this item ✅ successfully on ff878dd

Thanks, nice UI improvement


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.

@RickR2H
Copy link
Member

RickR2H commented Aug 17, 2021

I have tested this item ✅ successfully on ff878dd

This layout is a lot more clear.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.

@Quy Quy removed the PR-4.0-dev label Aug 17, 2021
@Quy
Copy link
Contributor

Quy commented Aug 17, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev RTC This Pull Request is Ready To Commit labels Aug 17, 2021
@Quy Quy added this to the Joomla 4.0.3 milestone Aug 25, 2021
@Quy Quy merged commit 60a0f05 into joomla:4.0-dev Aug 25, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 25, 2021
@Quy
Copy link
Contributor

Quy commented Aug 25, 2021

Thanks!

@Fedik Fedik deleted the subform-styling branch August 25, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants