-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] [4.0] Fix wrong number of parameters for sprintf #35148
[3.10] [4.0] Fix wrong number of parameters for sprintf #35148
Conversation
Co-authored-by: Ricardo <33345530+ricardo1709@users.noreply.github.com>
@ricardo1709 Done. Ready for tests/reviews. |
@ricardo1709 Unfortunately approval is nice but doesn't count like a test. Could you mark it in the issue tracker, too? Thanks in advance. |
I have tested this item ✅ successfully on 0278808 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35148. |
@ricardo1709 Thanks. |
@ricardo1709 Could you test again? Thanks in advance. |
I have tested this item ✅ successfully on 8bfe157 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35148. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging thanks
Pull Request for Issue #35122 .
Summary of Changes
This pull request (PR) fixes the wrong number of parameters in the 1st and the 3rd call to
sprintf
reported with issue #35122 .The 2nd call reported in the issue is J4 only and has been already fixed with this commit in the 4.0-dev branch: 76875db
In addition this PR fixes the same mistake for the call to
\JText::sprintf
just above the 1st reported issue. The language stingJLIB_MAIL_INVALID_EMAIL_SENDER
uses nearly the same text with the same two%s
as the reported issue in both 3.10-dev and 4.0-dev.I decided not to fix that language string
JLIB_MAIL_INVALID_EMAIL_SENDER
in order not to cause translation works.Not sure if this PR fixes these issues in the best way, but it should work.
All fixes in this PR here need to be merged up into 4.0-dev after having been merged into 3.10-dev.
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Wrong number of parameters in calls to
sprintf
and\JText::sprintf
.Expected result AFTER applying this Pull Request
Right number of parameters in calls to
sprintf
and\JText::sprintf
.Documentation Changes Required
None.